third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html - Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove CanvasRenderingContextBase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-expected.txt » ('j') | third_party/WebKit/Source/core/html/canvas/OffscreenCanvas.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description("Tests that the constructor of the OffscreenCanvas can be called on the main thread");	4 description("Tests that the OffscreenCanvas can be called on the main thread");

5	5

6 var aCanvas = new OffscreenCanvas(50, 50);	6 var aCanvas = new OffscreenCanvas(50, 50);

7 shouldBe("aCanvas.width", "50");	7 shouldBe("aCanvas.width", "50");

8 shouldBe("aCanvas.height", "50");	8 shouldBe("aCanvas.height", "50");

9	9

10 aCanvas.width = 100;	10 aCanvas.width = 100;

11 aCanvas.height = 100;	11 aCanvas.height = 100;

12 shouldBe("aCanvas.width", "100");	12 shouldBe("aCanvas.width", "100");

13 shouldBe("aCanvas.height", "100");	13 shouldBe("aCanvas.height", "100");

	14

	15 shouldNotThrow("aCanvas.getContext('2d')");
	Justin Novosad 2016/03/02 15:41:50 You should test the return value. Something like t You should test the return value. Something like this: var ctx; shouldNotThrow("ctx = aCanvas.getContext('2d')"); shouldBe("'[object OffscreenCanvasRenderingContext2D]'", "toString.call(ctx)"); xlai (Olivia) 2016/03/03 22:50:06 Done. Show quoted text On 2016/03/02 15:41:50, Justin Novosad wrote: > You should test the return value. Something like this: > var ctx; > shouldNotThrow("ctx = aCanvas.getContext('2d')"); > shouldBe("'[object OffscreenCanvasRenderingContext2D]'", "toString.call(ctx)"); Done.
14 </script>	16 </script>

OLD	NEW