third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html - Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with master and fix merge conflicts Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Tests basic functionalities of offscreenCanvas.getContext on the ma in thread");

	5

	6 // Tests onstructor of OffscreenCanvas and length/width change

	7 var aCanvas = new OffscreenCanvas(50, 50);
	Justin Novosad 2016/03/07 15:30:26 Not new to this CL, but you should also test the e Not new to this CL, but you should also test the edge cases. What happens if one of the dimensions is 0 or is of the wrong type? Same thing for setting width and height directly. Also, you should use different values for width and height, otherwise the test is not verifying that the two aren't inverted.
	8 shouldBe("aCanvas.width", "50");

	9 shouldBe("aCanvas.height", "50");

	10

	11 aCanvas.width = 100;

	12 aCanvas.height = 100;

	13 shouldBe("aCanvas.width", "100");

	14 shouldBe("aCanvas.height", "100");

	15

	16 // Tests object type of getContext('2d')

	17 var ctx;

	18 shouldNotThrow("ctx = aCanvas.getContext('2d')");

	19 shouldBeType("ctx", "OffscreenCanvasRenderingContext2D");

	20

	21 // Calling getContext on a different context type will return null

	22 var ctx2 = aCanvas.getContext("webgl");

	23 shouldBeNull("ctx2");
	Justin Novosad 2016/03/07 15:30:26 This is good, because this test will still be corr This is good, because this test will still be correct once we start supporting webgl.
	24

	25 // Calling getContext on the same context type will return the original context type

	26 var ctx3 = aCanvas.getContext("2d");

	27 shouldBeNonNull("ctx3");

	28 shouldBeTrue("ctx3 == ctx");

	29

	30 // Calling getContext on an unimplemented context type will return null

	31 var bCanvas = new OffscreenCanvas(20, 20);

	32 var ctx4 = bCanvas.getContext("webgl");
	Justin Novosad 2016/03/07 15:30:26 This test will break the day we support WebGL, mig This test will break the day we support WebGL, might as well use "bogus" instead.
	33 shouldBeNull("ctx4");

	34 </script>

OLD	NEW