third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html - Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html

Issue 1748163003: Add rendering context and rendering 2D context to OffscreenCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with master and fix merge conflicts Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html ('K') | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker-expected.txt » ('j') | third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <script src="../../resources/js-test.js"></script>

	4 <body>

	5 <script id="myWorker" type="text/worker">

	6 self.onmessage = function(e) {

	7 var aCanvas = new OffscreenCanvas(50, 50);

	8 try {

	9 var ctx = aCanvas.getContext('2d');

	10 if (toString.call(ctx) != '[object OffscreenCanvasRenderingContext2D]') {

	11 self.postMessage({ outcome : "error", errorMessage :

	12 "aCanvas.getContext('2d') does not return [object OffscreenCanvasR enderingContext2D]" });

	13 } else {

	14 self.postMessage({ outcome : "success", errorMessage : "" });

	15 }

	16 } catch (e) {

	17 self.postMessage({ outcome : "error", errorMessage : e });

	18 }

	19 };

	20 </script>

	21

	22 <script>

	23 jsTestIsAsync = true;

	24 description("Tests that the 2D context of OffscreenCanvas can be constructed on a worker thread.");

	25

	26 function makeWorker(script) {

	27 var blob = new Blob([script]);

	28 return new Worker(URL.createObjectURL(blob));

	29 }

	30

	31 function handleMessageFromWorker(msg) {

	32 switch (msg.data.outcome) {
	Justin Novosad 2016/03/07 15:30:26 This test is more complex than necessary. Instead This test is more complex than necessary. Instead of posting a structure back from the worker, you should just post a single string that either contains "success" or an error message. Then this function could just be: shouldBe('success', msg.data);
	33 case 'success':

	34 testPassed("getContext('2d') correctly returns [object OffscreenCanvasRend eringContext2D].");

	35 break;

	36 case 'error':

	37 testFailed(msg.data.errorMessage);

	38 break;

	39 default:

	40 testFailed("Unexpected failure");

	41 break;

	42 }

	43 finishJSTest();

	44 }

	45

	46 var worker = makeWorker(document.getElementById('myWorker').textContent);

	47 worker.addEventListener('message', handleMessageFromWorker);

	48 worker.postMessage("");

	49 </script>

	50

	51 </body>

	52 </html>

OLD	NEW