Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: tests/language/language.status

Issue 1748153003: Adjust expectations of library_env_test to take into account noopt, precompiled and product mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/library_env_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/language.status
diff --git a/tests/language/language.status b/tests/language/language.status
index 65ece61162540a22bdd94d79f19732c75c0757bb..42bb58b71cd1749f96a5c628f06fd67d4b608988 100644
--- a/tests/language/language.status
+++ b/tests/language/language.status
@@ -181,14 +181,20 @@ regress_22443_test: Skip
[ $runtime == vm && $mode == product ]
vm/type_vm_test: Fail,OK # Expects exact type name.
-[ $compiler == none && $browser ]
+[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) && $browser ]
# The following tests are supposed to fail.
library_env_test/has_io_support: RuntimeError, OK
library_env_test/has_no_html_support: RuntimeError, OK
-library_env_test/has_no_mirror_support: RuntimeError, OK
-[ $compiler == none && $browser != true ]
+[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) && $browser != true ]
# The following tests are supposed to fail.
library_env_test/has_html_support: RuntimeError, OK
library_env_test/has_no_io_support: RuntimeError, OK
+
+[ $compiler == none && $noopt == false && $mode != product ]
+# The following tests are supposed to fail.
library_env_test/has_no_mirror_support: RuntimeError, OK
+
+[ $noopt || $compiler == precompiler || $mode == product ]
+# The following tests are supposed to fail.
+library_env_test/has_mirror_support: RuntimeError, OK
« no previous file with comments | « no previous file | tests/language/library_env_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698