Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1748153003: Adjust expectations of library_env_test to take into account noopt, precompiled and product mode. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
floitsch, Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust expectations of library_env_test to take into account noopt, precompiled and product mode. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/7adcf94b754746f64ada55987f9e8dfd0ceae279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M tests/language/language.status View 1 chunk +9 lines, -3 lines 0 comments Download
M tests/language/library_env_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-01 00:26:45 UTC) #2
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-01 01:04:37 UTC) #3
rmacnak
Committed patchset #1 (id:1) manually as 7adcf94b754746f64ada55987f9e8dfd0ceae279 (presubmit successful).
4 years, 9 months ago (2016-03-01 01:11:12 UTC) #5
floitsch
4 years, 9 months ago (2016-03-01 10:34:25 UTC) #6
Message was sent while issue was closed.
LGTM. thanks!

Powered by Google App Engine
This is Rietveld 408576698