Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1748143004: Revert of [crankshaft] Inline hasOwnProperty when used in fast-case for-in (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Inline hasOwnProperty when used in fast-case for-in (patchset #1 id:40001 of https://codereview.chromium.org/1742253002/ ) Reason for revert: ARM64 GCStress failure Original issue's description: > [crankshaft] Inline hasOwnProperty when used in fast-case for-in > > e.g., > > for (var k in o) { > if (!o.hasOwnProperty(k)) continue; > ... > } > > without enumerable properties on the prototype chain of o. > > BUG= > > Committed: https://crrev.com/dec80752eb344dfeb85588e61ac0afd22b11aadb > Cr-Commit-Position: refs/heads/master@{#34379} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b5487307db6ce231e225710d2e1a4c4c8bb0561f Cr-Commit-Position: refs/heads/master@{#34380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -51 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/objects.h View 1 chunk +34 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Toon Verwaest
Created Revert of [crankshaft] Inline hasOwnProperty when used in fast-case for-in
4 years, 9 months ago (2016-03-01 09:00:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748143004/1
4 years, 9 months ago (2016-03-01 09:00:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 09:00:58 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:01:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5487307db6ce231e225710d2e1a4c4c8bb0561f
Cr-Commit-Position: refs/heads/master@{#34380}

Powered by Google App Engine
This is Rietveld 408576698