Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1748143002: Read got_revision_mapping from built in spec (Closed)

Created:
4 years, 9 months ago by hinoka
Modified:
4 years, 9 months ago
Reviewers:
martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Read got_revision_mapping from built in spec Sometimes the spec passed in via parameters also have got_revision_mapping that we want to use. BUG=590788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
martiniss
lgtm
4 years, 9 months ago (2016-02-29 23:48:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748143002/1
4 years, 9 months ago (2016-02-29 23:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748143002/1
4 years, 9 months ago (2016-02-29 23:49:26 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 23:51:49 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299015

Powered by Google App Engine
This is Rietveld 408576698