Set pointer type for the emulated touch events

Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
Committed: https://crrev.com/8822f1884b81370ff2f0a44b33a22e9869514d7f
Cr-Commit-Position: refs/heads/master@{#378560}

[Navid Zolghadr, 2016-03-01 14:53:13]

Description was changed from

==========
Set pointer type for emulated touch event

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

to

==========
Set pointer type for emulated touch event

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

[Navid Zolghadr, 2016-03-01 14:53:26]

Description was changed from

==========
Set pointer type for emulated touch event

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

to

==========
Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

[Navid Zolghadr, 2016-03-01 14:54:01]

nzolghadr@chromium.org changed reviewers:
+ mustaq@chromium.org, rbyers@chromium.org, tdresser@chromium.org

[Rick Byers, 2016-03-01 15:03:24]

Thanks!  Is there an existing test for these events that can be easily updated
to also listen for pointer events and check pointerType?

[Navid Zolghadr, 2016-03-01 15:33:51]

On 2016/03/01 15:03:24, Rick Byers wrote:
> Thanks!  Is there an existing test for these events that can be easily updated
> to also listen for pointer events and check pointerType?

It seems that there is this touch_emulator_unittest file which has some tests.
But I doubt it has anything related to this as It doesn't seem the test bots are
failing. But I can investigate adding new tests to that. The only problem is
that I don't know how to run these tests or where to look to find how to run
them. Do you have any idea about it?

[Rick Byers, 2016-03-01 15:47:20]

rbyers@chromium.org changed reviewers:
+ dgozman@chromium.org
- tdresser@chromium.org

[Rick Byers, 2016-03-01 15:48:42]

On 2016/03/01 15:33:51, Navid Zolghadr wrote:
> On 2016/03/01 15:03:24, Rick Byers wrote:
> > Thanks!  Is there an existing test for these events that can be easily
updated
> > to also listen for pointer events and check pointerType?
> 
> It seems that there is this touch_emulator_unittest file which has some tests.
> But I doubt it has anything related to this as It doesn't seem the test bots
are
> failing. But I can investigate adding new tests to that. The only problem is
> that I don't know how to run these tests or where to look to find how to run
> them. Do you have any idea about it?

Yep.  Searching the tree for touch_emulator_unittests.cc you can see it gets
built into content_unittests.  Most chromium tests (other than LayoutTests) us
the gtest framework.  Details on running the tests here:
https://www.chromium.org/developers/testing/running-tests

+dgozman who wrote / owns the touch emulator.

[dgozman, 2016-03-01 18:24:25]

We don't go as far as to test pointer events coming from emulated touch. But
adding the check to touch_emulator_unittest won't hurt anyway.
I'm not sure whether that's enough to guarantee correct pointer events though,
Rick should know better.

[Rick Byers, 2016-03-01 20:05:48]

On 2016/03/01 18:24:25, dgozman wrote:
> We don't go as far as to test pointer events coming from emulated touch. But
> adding the check to touch_emulator_unittest won't hurt anyway.
> I'm not sure whether that's enough to guarantee correct pointer events though,
> Rick should know better.

Ah I see, we test WHAT events get sent to the renderer, but not the specific
properties of those events.  This change is so small that it's not worth
expanding that pattern just for it.  So there's no good way to test this given
the current testing approach.

LGTM as-is

[Navid Zolghadr, 2016-03-01 20:23:48]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-03-01 20:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748103002/1

[commit-bot: I haz the power, 2016-03-01 20:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 20:35:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Navid Zolghadr, 2016-03-01 20:39:24]

Not sure if Dmitry is the owner or not at least the extension doesn't say so.
I'm adding Sadrul for the owner's approval.

[Rick Byers, 2016-03-01 20:40:34]

rbyers@chromium.org changed reviewers:
+ tdresser@chromium.org
- mustaq@chromium.org

[Navid Zolghadr, 2016-03-01 20:40:35]

nzolghadr@chromium.org changed reviewers:
+ mustaq@chromium.org, sadrul@chromium.org
- tdresser@chromium.org

[tdresser, 2016-03-01 20:47:04]

tdresser@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-03-01 20:47:04]

lgtm

[Navid Zolghadr, 2016-03-01 20:55:08]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-03-01 20:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748103002/1

[commit-bot: I haz the power, 2016-03-01 21:20:51]

Description was changed from

==========
Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

to

==========
Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

[commit-bot: I haz the power, 2016-03-01 21:20:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-01 21:22:20]

Description was changed from

==========
Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841
==========

to

==========
Set pointer type for the emulated touch events

Set pointerType of emulated touch points that are generated from
mouse events in dev tools.

BUG=590841

Committed: https://crrev.com/8822f1884b81370ff2f0a44b33a22e9869514d7f
Cr-Commit-Position: refs/heads/master@{#378560}
==========

[commit-bot: I haz the power, 2016-03-01 21:22:21]

Patchset 1 (id:??) landed as
https://crrev.com/8822f1884b81370ff2f0a44b33a22e9869514d7f
Cr-Commit-Position: refs/heads/master@{#378560}