SDK: Add a Makefile to build the C++ stuff.

SDK: Add a Makefile to build the C++ stuff.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/49e3235405cd7bdc20ec820418c4ee4b50f55f7e

[vardhan, 2016-02-29 20:56:37]

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile
File sdk_build/data/cpp/Makefile (right):

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile...
sdk_build/data/cpp/Makefile:97: $(MOJO_PUBLIC_CC_FILES):
$(MOJO_PUBLIC_MOJOM_CC_FILES)
what about header file dependencies, since a lot of the C++ bindings are
templated classes, constants, etc? 

(and it looks like g++/clang++ can help generated makefile targets by analyzing
includes, yay:
http://stackoverflow.com/questions/2394609/makefile-header-dependencies)

[viettrungluu, 2016-02-29 21:02:54]

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile
File sdk_build/data/cpp/Makefile (right):

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile...
sdk_build/data/cpp/Makefile:97: $(MOJO_PUBLIC_CC_FILES):
$(MOJO_PUBLIC_MOJOM_CC_FILES)
On 2016/02/29 20:56:37, vardhan wrote:
> what about header file dependencies, since a lot of the C++ bindings are
> templated classes, constants, etc? 
> 
> (and it looks like g++/clang++ can help generated makefile targets by
analyzing
> includes, yay:
> http://stackoverflow.com/questions/2394609/makefile-header-dependencies)

Blah blah blah. Apparently, you can't read -- see the comment at the top of the
file.

Generating dependencies turns out to be much harder than you think, especially
if you have generated files. (But even without, it's not easy.)

[vardhan, 2016-02-29 21:11:54]

lgtm

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile
File sdk_build/data/cpp/Makefile (right):

https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile...
sdk_build/data/cpp/Makefile:97: $(MOJO_PUBLIC_CC_FILES):
$(MOJO_PUBLIC_MOJOM_CC_FILES)
On 2016/02/29 21:02:54, viettrungluu wrote:
> On 2016/02/29 20:56:37, vardhan wrote:
> > what about header file dependencies, since a lot of the C++ bindings are
> > templated classes, constants, etc? 
> > 
> > (and it looks like g++/clang++ can help generated makefile targets by
> analyzing
> > includes, yay:
> > http://stackoverflow.com/questions/2394609/makefile-header-dependencies)
> 
> Blah blah blah. Apparently, you can't read.
that's uncalled for -- please practice courtesy when you ask someone for a code
review, or just in general.

> Generating dependencies turns out to be much harder than you think, especially
> if you have generated files. (But even without, it's not easy.)
this is a much better response

[viettrungluu, 2016-02-29 21:20:45]

On 2016/02/29 21:11:54, vardhan wrote:
> lgtm
> 
> https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile
> File sdk_build/data/cpp/Makefile (right):
> 
>
https://codereview.chromium.org/1748073002/diff/1/sdk_build/data/cpp/Makefile...
> sdk_build/data/cpp/Makefile:97: $(MOJO_PUBLIC_CC_FILES):
> $(MOJO_PUBLIC_MOJOM_CC_FILES)
> On 2016/02/29 21:02:54, viettrungluu wrote:
> > On 2016/02/29 20:56:37, vardhan wrote:
> > > what about header file dependencies, since a lot of the C++ bindings are
> > > templated classes, constants, etc? 
> > > 
> > > (and it looks like g++/clang++ can help generated makefile targets by
> > analyzing
> > > includes, yay:
> > > http://stackoverflow.com/questions/2394609/makefile-header-dependencies)
> > 
> > Blah blah blah. Apparently, you can't read.
> that's uncalled for -- please practice courtesy when you ask someone for a
code
> review, or just in general.

Sorry, you're right. Thank you for calling out my rudeness.

> 
> > Generating dependencies turns out to be much harder than you think,
especially
> > if you have generated files. (But even without, it's not easy.)
> this is a much better response

Also, to explain even further: It's made even worse/harder by wanting to put
output files -- .o and .mojom.{cc,h}/etc. -- not beside the source files.
(Presumably, you don't want the .d files beside the source files either.) And
then you have to be careful to make sure things work correctly when .mojom (and
.h) files are removed, etc. At that point, the Makefile isn't simple or clear
anymore.

[viettrungluu, 2016-02-29 21:21:51]

Description was changed from

==========
SDK: Add a Makefile to build the C++ stuff.

R=vardhan@google.com
==========

to

==========
SDK: Add a Makefile to build the C++ stuff.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/49e3235405cd7bdc20ec820418c...
==========

[viettrungluu, 2016-02-29 21:21:57]

Committed patchset #1 (id:1) manually as
49e3235405cd7bdc20ec820418c4ee4b50f55f7e (presubmit successful).