Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1747983002: Disabling 2 BrowserSideNavigationBrowserTest tests. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org, clamy, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling 2 BrowserSideNavigationBrowserTest tests. BUG=590782 Committed: https://crrev.com/1fe380c0e5012e03e5d1e5ad5d831fc65d30e0b6 Cr-Commit-Position: refs/heads/master@{#378342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M testing/buildbot/filters/isolate-extensions.content_browsertests.filter View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Łukasz Anforowicz
nasko@ - can you rubberstamp this? (I've added clamy@ and nick@ to CC, but they ...
4 years, 9 months ago (2016-02-29 18:09:17 UTC) #2
nasko
LGTM
4 years, 9 months ago (2016-02-29 18:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747983002/1
4 years, 9 months ago (2016-02-29 18:24:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/110438) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-02-29 18:30:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747983002/1
4 years, 9 months ago (2016-02-29 18:40:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/110462) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-02-29 18:46:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747983002/1
4 years, 9 months ago (2016-02-29 21:07:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/187797)
4 years, 9 months ago (2016-02-29 22:41:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747983002/1
4 years, 9 months ago (2016-02-29 22:50:21 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 00:34:25 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 00:35:36 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fe380c0e5012e03e5d1e5ad5d831fc65d30e0b6
Cr-Commit-Position: refs/heads/master@{#378342}

Powered by Google App Engine
This is Rietveld 408576698