Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1747933002: Fix spec-compliance bug in Array.prototype.join. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix spec-compliance bug in Array.prototype.join. The code used to [[Get]] the first element twice instead of once, which can be observed (one of the kangax tests does so). R=rossberg BUG= Committed: https://crrev.com/c4f39389ea2dad857a2415a783bc7fbc4bdf0f6b Cr-Commit-Position: refs/heads/master@{#34383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M src/js/array.js View 1 chunk +9 lines, -5 lines 0 comments Download
M test/mjsunit/array-join.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
4 years, 9 months ago (2016-02-29 16:29:28 UTC) #1
rossberg
lgtm
4 years, 9 months ago (2016-02-29 16:45:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747933002/1
4 years, 9 months ago (2016-03-01 08:13:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/10964)
4 years, 9 months ago (2016-03-01 08:17:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747933002/1
4 years, 9 months ago (2016-03-01 08:44:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 09:06:57 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:07:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4f39389ea2dad857a2415a783bc7fbc4bdf0f6b
Cr-Commit-Position: refs/heads/master@{#34383}

Powered by Google App Engine
This is Rietveld 408576698