Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1747893002: Revert of Add abilitly to query audit trail for batches by draw op (Closed)

Created:
4 years, 9 months ago by joshualitt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add abilitly to query audit trail for batches by draw op (patchset #4 id:60001 of https://codereview.chromium.org/1745513002/ ) Reason for revert: kInvalidID conflicts with an older xCode #define Original issue's description: > Add abilitly to query audit trail for batches by draw op > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745513002 > > Committed: https://skia.googlesource.com/skia/+/9b48a6e3f862076018cc7d63b180b6340f4873cd TBR=ethannicholas@google.com,jcgregorio@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/08fc80704d369508276c0bd9d34eb4f8cb2c2f54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -174 lines) Patch
M include/private/GrAuditTrail.h View 3 chunks +86 lines, -82 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 3 chunks +32 lines, -57 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/skiaserve/Request.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +5 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
joshualitt
Created Revert of Add abilitly to query audit trail for batches by draw op
4 years, 9 months ago (2016-02-29 14:32:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747893002/1
4 years, 9 months ago (2016-02-29 14:32:15 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 14:32:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/08fc80704d369508276c0bd9d34eb4f8cb2c2f54

Powered by Google App Engine
This is Rietveld 408576698