Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 1747803003: MacViews: Implement Tab Dragging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't set the window position inside the RunMoveLoop call. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
index 2799ba073f59cc573b860c6d5872c4b71e39a606..31e7bc6c51eeffd325b7d56a120ed688e45aeb52 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
@@ -390,6 +390,12 @@ void TabDragController::Drag(const gfx::Point& point_in_screen) {
&drag_bounds);
widget->SetVisibilityChangedAnimationsEnabled(true);
}
+
+ views::Widget* widget = GetAttachedBrowserWidget();
sky 2016/06/16 15:56:12 As this part is really a separate bug, could you c
themblsha 2016/06/17 14:58:07 There's already a bug for this: https://bugs.chrom
+ gfx::Rect bounds = widget->GetWindowBoundsInScreen();
+ bounds.Offset(point_in_screen.x() - start_point_in_screen_.x(),
+ point_in_screen.y() - start_point_in_screen_.y());
+ widget->SetBounds(bounds);
RunMoveLoop(GetWindowOffset(point_in_screen));
return;
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698