MacViews: Implement Tab Dragging

chrome/test/base/interactive_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_INTERACTIVE_TEST_UTILS_H_
 #define CHROME_TEST_BASE_INTERACTIVE_TEST_UTILS_H_
 
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "ui/base/test/ui_controls.h"
 
 namespace gfx {
 class Point;
 }
 
 #if defined(TOOLKIT_VIEWS)
 namespace views {
 class View;
 }
 #endif
 
 namespace ui_test_utils {
 
+#if defined(OS_MACOSX)
+// Moves the mouse to the |from| position, presses left mouse button,
+// then moves mouse to the |to| position, waits the |delay|, releases left mouse
+// button.
+// |steps| indicates number of intermediate points that are interpolated between
+// |from| and |to|.
+void DragAndDrop(const gfx::Point& from,
+                 const gfx::Point& to,
+                 base::TimeDelta delay = base::TimeDelta(),

[tapted, 2016/03/10 11:51:19]

can the delay argument be removed? It might help while debugging the test, but
if people are tempted to use it, it could lead to test flakiness.

[themblsha, 2016/03/10 17:18:58]

I thought that this delay would be useful for testing
tab_strip_drag_controller.mm as it has kTearDuration, and if we don't wait for
enough time the precise window bounds comparisons will fail.

+                 unsigned int steps = 1);

[tapted, 2016/03/10 11:51:19]

just int

[themblsha, 2016/03/10 17:18:58]

Done.

+#endif  // OS_MACOSX
+
 // Brings the native window for |browser| to the foreground. Returns true on
 // success.
 bool BringBrowserWindowToFront(const Browser* browser) WARN_UNUSED_RESULT;
 
 // Returns true if the View is focused.
 bool IsViewFocused(const Browser* browser, ViewID vid);
 
 // Simulates a mouse click on a View in the browser.
 void ClickOnView(const Browser* browser, ViewID vid);
 
@@ skipping 109 matching lines @@
 // ui_controls_linux.cc and ui_controls_mac.cc
 void ClickTask(ui_controls::MouseButton button,
                int state,
                const base::Closure& followup);
 
 }  // namespace internal
 
 }  // namespace ui_test_utils
 
 #endif  // CHROME_TEST_BASE_INTERACTIVE_TEST_UTILS_H_