MacViews: Implement Tab Dragging

ui/views/widget/native_widget_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <utility>
 
@@ skipping 274 matching lines @@
   if (modal_type == ui::MODAL_TYPE_NONE)
     return;
 
   // System modal windows not implemented (or used) on Mac.
   DCHECK_NE(ui::MODAL_TYPE_SYSTEM, modal_type);
   DCHECK(bridge_->parent());
   // Everyhing happens upon show.
 }
 
 gfx::Rect NativeWidgetMac::GetWindowBoundsInScreen() const {
-  return gfx::ScreenRectFromNSRect([GetNativeWindow() frame]);
+  // -[NSWindow frame] doesn't update during a window drag. This is not what
+  // toolkit-views expects, so ask the window server directly.
+  //
+  // Note: Moving the window using the window server is asynchronous, and it can
+  // continue sending the frame updates (using NSWindowMovedEventType event)
+  // even after the mouse button is released.
+  NSRect frame_rect = [GetNativeWindow() frame];
+  if (bridge_->IsRunMoveLoopActive())
+    frame_rect = bridge_->WindowServerFrame();
+  return gfx::ScreenRectFromNSRect(frame_rect);
 }
 
 gfx::Rect NativeWidgetMac::GetClientAreaBoundsInScreen() const {
   NSWindow* window = GetNativeWindow();
-  return gfx::ScreenRectFromNSRect(
-      [window contentRectForFrameRect:[window frame]]);
+  NSRect frame_rect = [window frame];
+  // -[NSWindow frame] doesn't update during a window drag. This is not what
+  // toolkit-views expects, so ask the window server directly.
+  //
+  // Note: Moving the window using the window server is asynchronous, and it can
+  // continue sending the frame updates (using NSWindowMovedEventType event)
+  // even after the mouse button is released.
+  if (bridge_->IsRunMoveLoopActive())
+    frame_rect = bridge_->WindowServerFrame();
+  return gfx::ScreenRectFromNSRect([window contentRectForFrameRect:frame_rect]);
 }
 
 gfx::Rect NativeWidgetMac::GetRestoredBounds() const {
   return bridge_ ? bridge_->GetRestoredBounds() : gfx::Rect();
 }
 
 void NativeWidgetMac::SetBounds(const gfx::Rect& bounds) {
   if (bridge_)
     bridge_->SetBounds(bounds);
 }
@@ skipping 227 matching lines @@
 }
 
 gfx::Rect NativeWidgetMac::GetWorkAreaBoundsInScreen() const {
   return gfx::ScreenRectFromNSRect([[GetNativeWindow() screen] visibleFrame]);
 }
 
 Widget::MoveLoopResult NativeWidgetMac::RunMoveLoop(
     const gfx::Vector2d& drag_offset,
     Widget::MoveLoopSource source,
     Widget::MoveLoopEscapeBehavior escape_behavior) {
-  NOTIMPLEMENTED();
-  return Widget::MOVE_LOOP_CANCELED;
+  if (!bridge_)
+    return Widget::MOVE_LOOP_CANCELED;
+
+  return bridge_->RunMoveLoop(drag_offset);
 }
 
 void NativeWidgetMac::EndMoveLoop() {
-  NOTIMPLEMENTED();
+  if (bridge_)
+    bridge_->EndMoveLoop();
 }
 
 void NativeWidgetMac::SetVisibilityChangedAnimationsEnabled(bool value) {
   NOTIMPLEMENTED();
 }
 
 void NativeWidgetMac::SetVisibilityAnimationDuration(
     const base::TimeDelta& duration) {
   NOTIMPLEMENTED();
 }
@@ skipping 166 matching lines @@
   [[ViewsNSWindowCloseAnimator alloc] initWithWindow:window];
 }
 
 - (void)animationDidEnd:(NSAnimation*)animation {
   [window_ close];
   [animation_ setDelegate:nil];
   [self release];
 }
 
 @end