MacViews: Implement Tab Dragging

ui/views/widget/native_widget_mac.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_NATIVE_WIDGET_MAC_H_
 #define UI_VIEWS_WIDGET_NATIVE_WIDGET_MAC_H_
 
 #include "base/macros.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/widget/native_widget_private.h"
@@ skipping 29 matching lines @@
   // Deletes |bridge_| and informs |delegate_| that the native widget is
   // destroyed.
   // This is usually called from the NSWindowDelegate. A derived class can
   // override this method for an early hook into the native window teardown.
   virtual void OnWindowWillClose();
 
   // Returns the vertical position that sheets should be anchored, in pixels
   // from the bottom of the window.
   virtual int SheetPositionY();
 
+  // Returns the actual frame as the WindowServer sees it.
+  gfx::Rect WindowServerFrame() const;

[tapted, 2016/04/13 08:28:13]

Can this go on BridgedNativeWidget instead?

It's fine for NativeWidgetMac to call bridge_->WindowServerFrame.
(NativeWidgetMac should be lightweight, since things in chrome/browser can
inherit from it, and it will be harder to share stuff we put on it when we need
things for aura)

And I think it should be something like

NSRect BridgedNativeWidget::GetFrameIncludingLiveDrag() {
  if (IsRunMoveLoopActive()) {
    return WindowServerFrame(window_);
  }
  return [window_ frame];
}

WindowServerFrame can probably be put in an anonymous namespace, or even
integrated into GetFrameIncludingLiveDrag()


this will allow GetWindowBoundsInScreen and GetClientAreaBoundsInScreen to share
more logic

[themblsha, 2016/04/18 09:30:02]

Well, I moved it to BridgedNativeWidget, as it uses WindowServerFrame() after
-setFrame: in a DCHECK.

+
   // internal::NativeWidgetPrivate:
   void InitNativeWidget(const Widget::InitParams& params) override;
   void OnWidgetInitDone() override;
   NonClientFrameView* CreateNonClientFrameView() override;
   bool ShouldUseNativeFrame() const override;
   bool ShouldWindowContentsBeTransparent() const override;
   void FrameTypeChanged() override;
   Widget* GetWidget() override;
   const Widget* GetWidget() const override;
   gfx::NativeView GetNativeView() const override;
@@ skipping 89 matching lines @@
   scoped_ptr<BridgedNativeWidget> bridge_;
 
   Widget::InitParams::Ownership ownership_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeWidgetMac);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_NATIVE_WIDGET_MAC_H_