Make the ENABLE_APP_LIST build flag work on Linux

Make the ENABLE_APP_LIST build flag work on Linux

Chromium is only compiling for enable_app_list=true. This CL makes the flag
work so that enable_app_list=false will compile as well.

[wierichs, 2016-02-29 02:28:52]

wierichs@google.com changed reviewers:
+ mgiuca@chromium.org

[wierichs, 2016-02-29 02:28:53]

Here's a first version of the app list flag working for both true and false.

[Matt Giuca, 2016-02-29 02:52:38]

Good work! I have a few comments.

Have you tested with both GN and GYP?

https://codereview.chromium.org/1747773002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/1747773002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:135: const
SkColor dialogSeparatorColor = SkColorSetRGB(0xD1, 0xD1, 0xD1);
No need for a comment here. I think this is fine (since it is only used in this
one place). Also you should never have commented-out lines of code.

Rename this constant to kDialogSeparatorColor. We still use the k prefix for
constants even if they are local (see kHorizontalSeparatorHeight just above).

https://codereview.chromium.org/1747773002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/1747773002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:66: #if
defined(ENABLE_APP_LIST)
Why is this app-list specific? This is controls whether the apps are pinned to
the Ash shelf. It should be available even if app list is disabled (despite the
name of those enums).

[Matt Giuca, 2016-03-01 04:27:21]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 04:27:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747773002/20001

[Matt Giuca, 2016-03-01 04:27:41]

I've started a CQ dry run so we can properly test this on GN and GYP on all
platforms.

[commit-bot: I haz the power, 2016-03-01 04:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 04:43:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2016-03-01 04:54:38]

On 2016/03/01 04:43:10, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Many bots are failing to compile --- including the Linux ones. See:
- Windows:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
- Mac:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
- Linux:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
- Chrome OS:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

:(

Many of these will be the same problem overlapping. Start by looking at the
Linux ones. (I'm confused that you're able to compile locally given that it's a
failure in app_list_service_linux. But try building unit_tests and browser_tests
locally as a starter.

Also, app_list_service_win is failing to compile. I think you could figure this
out (despite not having access to a Windows machine). Ask me if you want to
compile it on Windows, but you could start by trying to fix this then we can run
it again on the bots.

[Matt Giuca, 2016-05-03 07:31:38]

Description was changed from

==========
Make the ENABLE_APP_LIST build flag work on Linux

Chromium is only compiling for enable_app_list=true. This CL makes the flag
work so that enable_app_list=false will compile as well.
==========

to

==========
Make the ENABLE_APP_LIST build flag work on Linux

Chromium is only compiling for enable_app_list=true. This CL makes the flag
work so that enable_app_list=false will compile as well.
==========

[Matt Giuca, 2016-05-03 07:32:29]

tapted@ has resumed work on this in:
https://codereview.chromium.org/1861233003/

Closing this CL as redundant.