Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1747763002: Remove OSX-specific <meter> rendering. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OSX-specific <meter> rendering. Intent to Remove thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T_soy0IYt7E/6gxId0IWEAAJ This CL removes the following -webkit-appearance values, and change the default <meter> rendering on OSX same as other platforms. - continuous-capacity-level-indicator - discrete-capacity-level-indicator - relevancy-level-indicator - rating-level-indicator As the result, this CL removes LayoutMeter class, and it also removes all classes in MeterShadowElements by moving element-specific code to HTMLMeterElement. BUG=590129 Committed: https://crrev.com/cffa8776559bd41f3f225b4ca07745131790e84f Cr-Commit-Position: refs/heads/master@{#378178}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -1656 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-capacity.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt View 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt View 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt View 1 chunk +0 lines, -118 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt View 14 chunks +56 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt View 3 chunks +60 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt View 6 chunks +34 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt View 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt View 1 chunk +0 lines, -178 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMeterElement.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMeterElement.cpp View 4 chunks +32 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/MeterShadowElement.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/MeterShadowElement.cpp View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/WebKit/Source/core/layout/LayoutMeter.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/core/layout/LayoutMeter.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 3 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 2 chunks +0 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 5 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/ThemeTypes.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-02-29 04:36:36 UTC) #7
keishi
LGTM
4 years, 9 months ago (2016-02-29 05:26:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747763002/20001
4 years, 9 months ago (2016-02-29 05:44:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-02-29 06:46:07 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 06:47:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cffa8776559bd41f3f225b4ca07745131790e84f
Cr-Commit-Position: refs/heads/master@{#378178}

Powered by Google App Engine
This is Rietveld 408576698