Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1747753003: [crankshaft] Check checked_function->ActualValue() in BuildWrapReceiver (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Check checked_function->ActualValue() in BuildWrapReceiver Given that an additional map-check is inserted for function, we need to check the underlying value. BUG= Committed: https://crrev.com/437616e335c708c31ccf5128815945da8c1acd30 Cr-Commit-Position: refs/heads/master@{#34359}

Patch Set 1 : #

Patch Set 2 : Pass in checked to HWrapReceiver ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/crankshaft/hydrogen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-02-29 10:35:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747753003/20001
4 years, 9 months ago (2016-02-29 10:36:18 UTC) #5
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-02-29 10:36:41 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14468)
4 years, 9 months ago (2016-02-29 10:48:12 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747753003/40001
4 years, 9 months ago (2016-02-29 10:49:31 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 11:08:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747753003/40001
4 years, 9 months ago (2016-02-29 11:30:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-02-29 11:33:01 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 11:33:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/437616e335c708c31ccf5128815945da8c1acd30
Cr-Commit-Position: refs/heads/master@{#34359}

Powered by Google App Engine
This is Rietveld 408576698