Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1747693002: Switch plugins/netscape-plugin-map-data-to-src.html to the PPAPI test plugin. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
raymes
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch plugins/netscape-plugin-map-data-to-src.html to the PPAPI test plugin. BUG=474535 Committed: https://crrev.com/3ef55130a0b1fb75b21895c57dc3d276518c91fb Cr-Commit-Position: refs/heads/master@{#378164}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M ppapi/tests/blink_test_plugin.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/plugins/netscape-plugin-map-data-to-src.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/plugins/netscape-plugin-map-data-to-src-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/plugins/plugin-map-data-to-src.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/plugins/plugin-map-data-to-src-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dcheng
4 years, 9 months ago (2016-02-28 07:24:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747693002/1
4 years, 9 months ago (2016-02-28 07:25:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-28 08:32:27 UTC) #7
raymes
lgtm https://codereview.chromium.org/1747693002/diff/1/ppapi/tests/blink_test_plugin.cc File ppapi/tests/blink_test_plugin.cc (right): https://codereview.chromium.org/1747693002/diff/1/ppapi/tests/blink_test_plugin.cc#newcode8 ppapi/tests/blink_test_plugin.cc:8: #include <map> nit: is this used? https://codereview.chromium.org/1747693002/diff/1/ppapi/tests/blink_test_plugin.cc#newcode41 ppapi/tests/blink_test_plugin.cc:41: ...
4 years, 9 months ago (2016-02-29 00:03:06 UTC) #8
dcheng
https://codereview.chromium.org/1747693002/diff/1/ppapi/tests/blink_test_plugin.cc File ppapi/tests/blink_test_plugin.cc (right): https://codereview.chromium.org/1747693002/diff/1/ppapi/tests/blink_test_plugin.cc#newcode8 ppapi/tests/blink_test_plugin.cc:8: #include <map> On 2016/02/29 at 00:03:06, raymes wrote: > ...
4 years, 9 months ago (2016-02-29 00:11:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747693002/20001
4 years, 9 months ago (2016-02-29 00:11:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 01:39:57 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 01:41:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ef55130a0b1fb75b21895c57dc3d276518c91fb
Cr-Commit-Position: refs/heads/master@{#378164}

Powered by Google App Engine
This is Rietveld 408576698