Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 174763002: NaCl: Update revision in DEPS, r12790 -> r12794 (Closed)

Created:
6 years, 10 months ago by Mark Seaborn
Modified:
6 years, 10 months ago
CC:
chromium-reviews, bradn, Roland McGrath, native-client-reviews_googlegroups.com, noelallen_use_chromium, teravest
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r12790 -> r12794 This pulls in the following Native Client changes: r12791: (bradnelson) Invoke the compiler to locate the mig definitions files. r12792: (teravest) Remove unused NACL_MANIFEST_UNREF message. r12793: (mcgrathr) Update x86 toolchains in TOOL_REVISIONS r12794: (noelallen) Re-order bionic build to support libc++.so. BUG=none TEST=browser_tests and nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Roland McGrath
LGTM This will get some x86 compiler fixes into the SDK.
6 years, 10 months ago (2014-02-21 17:49:41 UTC) #1
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-21 17:57:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 17:57:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 17:57:58 UTC) #4
bradn
lgtm
6 years, 10 months ago (2014-02-21 18:20:45 UTC) #5
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-21 18:21:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/174763002/1
6 years, 10 months ago (2014-02-21 18:22:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:53 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:24:24 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:24:24 UTC) #11
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 10 months ago (2014-02-21 19:20:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/174763002/1
6 years, 10 months ago (2014-02-21 19:21:31 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:13:22 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268038
6 years, 10 months ago (2014-02-21 22:13:23 UTC) #15
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-21 23:57:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/174763002/1
6 years, 10 months ago (2014-02-22 00:01:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/174763002/1
6 years, 10 months ago (2014-02-22 01:29:49 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 06:47:02 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268462
6 years, 10 months ago (2014-02-22 06:47:02 UTC) #20
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-23 05:24:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/174763002/1
6 years, 10 months ago (2014-02-23 05:26:43 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-23 11:28:16 UTC) #23
Message was sent while issue was closed.
Change committed as 252853

Powered by Google App Engine
This is Rietveld 408576698