Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1747443003: Revert of Enable RAW codec for Windows (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
Reviewers:
msarett, scroggo, yujieqin
CC:
reviews_skia.org, adaubert, mboehme
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enable RAW codec for Windows (patchset #8 id:140001 of https://codereview.chromium.org/1738913002/ ) Reason for revert: I don't think there's anything wrong with this per-se, but the 32-bit Windows bots are running out of memory while running these tests now. (You'll see something like c:\0\build\slave\workdir\build\skia\include\core\skbitmap.h:247: fatal error: ""sk_throw"" in the log.) We run these tests in parallel, and sometimes these 32-bit processes try to use more than the 2-3G RAM they can allocate. Seems like this is a particularly memory-intense process? If we reland this, we might want to blacklist these tests on the 32-bit Windows bots. The 64-bit bots should have access to tons and tons of RAM and let us keep testing for Windows. Original issue's description: > Enable RAW codec for Windows > > * Fix the exception catching > * Set preprocessor differently for MSVC > > BUG=skia:4889 (b/26958348) > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738913002 > > Committed: https://skia.googlesource.com/skia/+/474e4c3dd28b67f590851321f15d9983ef7fd031 TBR=scroggo@google.com,msarett@google.com,yujieqin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4889 (b/26958348) Committed: https://skia.googlesource.com/skia/+/cb3d4fc7d6fa8e303983b5a0c185737a5ba6bc02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -44 lines) Patch
M gyp/common_variables.gypi View 1 chunk +7 lines, -3 lines 0 comments Download
M gyp/dng_sdk.gyp View 1 chunk +1 line, -10 lines 0 comments Download
M src/codec/SkRawCodec.cpp View 4 chunks +12 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Enable RAW codec for Windows
4 years, 9 months ago (2016-02-27 00:57:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747443003/1
4 years, 9 months ago (2016-02-27 00:57:31 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 00:57:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cb3d4fc7d6fa8e303983b5a0c185737a5ba6bc02

Powered by Google App Engine
This is Rietveld 408576698