Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1747413002: Implement forwards compatibility for summary enums. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement forwards compatibility for summary enums. If an attempt is made to read an unrecognized enum value, then rather than crashing, we will read the default (first) value of the enum type. This facilitates forwards compatibility by ensuring that if a new enum value is added in the future, older code will still be able to read the resulting summary files without crashing. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ff6a744f38a2fa949c464d8fb9d52b3c7685bb5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-01 20:20:08 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-01 20:22:15 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-01 21:28:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff6a744f38a2fa949c464d8fb9d52b3c7685bb5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698