Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1747403002: Make Document.createAttribute lowercase the name (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 1 month ago
Reviewers:
tkent, chrishtr, foolip
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Document.createAttribute lowercase the name According to the spec we should lowercase the attribute name when dealing with a HTMLDocument [1]. Usage of this feature is below 0.002% https://www.chromestatus.com/metrics/feature/timeline/popularity/844 Behavior matches Firefox and Safari. BUG=502301 [1] https://dom.spec.whatwg.org/#dom-document-createattribute Committed: https://crrev.com/70b150189216d4b069582f794b5757fe628a02eb Cr-Commit-Position: refs/heads/master@{#431919}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix tests #

Messages

Total messages: 18 (10 generated)
rwlbuis
PTAL. From use counter information this should be safe to do, and FF and Webkit ...
4 years, 1 month ago (2016-11-14 15:57:27 UTC) #5
foolip
Use counter is https://www.chromestatus.com/metrics/feature/timeline/popularity/844 Given that two browsers have already done this I'm inclined to ...
4 years, 1 month ago (2016-11-14 16:11:40 UTC) #7
rwlbuis
On 2016/11/14 16:11:40, foolip wrote: > Use counter is > https://www.chromestatus.com/metrics/feature/timeline/popularity/844 I added that to ...
4 years, 1 month ago (2016-11-14 16:30:13 UTC) #9
chrishtr
lgtm
4 years, 1 month ago (2016-11-14 19:13:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1747403002/40001
4 years, 1 month ago (2016-11-14 19:24:04 UTC) #12
foolip
lgtm too. +tkent@ FYI
4 years, 1 month ago (2016-11-14 19:31:13 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-14 22:36:27 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 22:39:47 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70b150189216d4b069582f794b5757fe628a02eb
Cr-Commit-Position: refs/heads/master@{#431919}

Powered by Google App Engine
This is Rietveld 408576698