Subzero: Print constant pool info with --szstats.

Subzero: Print constant pool info with --szstats.

BUG= none
R=eholk@chromium.org, jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3d5e08dc415e864f16d6cd22a37e8f61c2680943

[Jim Stichnoth, 2016-03-01 18:05:37]

Description was changed from

==========
Subzero: Print constant pool info with --szstats.

BUG= none
==========

to

==========
Subzero: Print constant pool info with --szstats.

BUG= none
==========

[Jim Stichnoth, 2016-03-01 18:05:37]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Eric Holk, 2016-03-01 19:26:39]

lgtm

https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp#ne...
src/IceGlobalContext.cpp:219: void GlobalContext::CodeStats::dump(const
IceString &Name, GlobalContext *Ctx) {
Optional, but I'd consider passing Ctx as a reference (&) instead of a pointer.

[John, 2016-03-01 20:02:09]

lgtm

https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp#ne...
src/IceGlobalContext.cpp:219: void GlobalContext::CodeStats::dump(const
IceString &Name, GlobalContext *Ctx) {
On 2016/03/01 19:26:39, Eric Holk wrote:
> Optional, but I'd consider passing Ctx as a reference (&) instead of a
pointer.

Please, do not pass non-const references to methods. :(

[Jim Stichnoth, 2016-03-01 20:22:32]

Description was changed from

==========
Subzero: Print constant pool info with --szstats.

BUG= none
==========

to

==========
Subzero: Print constant pool info with --szstats.

BUG= none
R=eholk@chromium.org, jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-03-01 20:22:33]

Committed patchset #1 (id:1) manually as
3d5e08dc415e864f16d6cd22a37e8f61c2680943 (presubmit successful).