Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1747333002: Subzero: Print constant pool info with --szstats. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/IceGlobalContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceGlobalContext.cpp View 4 chunks +20 lines, -4 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-01 18:05:44 UTC) #3
Eric Holk
lgtm https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp File src/IceGlobalContext.cpp (right): https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp#newcode219 src/IceGlobalContext.cpp:219: void GlobalContext::CodeStats::dump(const IceString &Name, GlobalContext *Ctx) { Optional, ...
4 years, 9 months ago (2016-03-01 19:26:39 UTC) #4
John
lgtm https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp File src/IceGlobalContext.cpp (right): https://codereview.chromium.org/1747333002/diff/1/src/IceGlobalContext.cpp#newcode219 src/IceGlobalContext.cpp:219: void GlobalContext::CodeStats::dump(const IceString &Name, GlobalContext *Ctx) { On ...
4 years, 9 months ago (2016-03-01 20:02:09 UTC) #5
Jim Stichnoth
4 years, 9 months ago (2016-03-01 20:22:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d5e08dc415e864f16d6cd22a37e8f61c2680943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698