Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1747213002: dart2js cps: Remove receiverIsNotNull from CPS nodes. (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Remove receiverIsNotNull from CPS nodes. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/dbaf47de5e9de11f894cc85629b5f394779bf78f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
It was a leftover from when we did not have refinement nodes throughout the whole ...
4 years, 9 months ago (2016-03-01 13:43:13 UTC) #2
Kevin Millikin (Google)
lgtm
4 years, 9 months ago (2016-03-01 13:52:48 UTC) #3
asgerf
4 years, 9 months ago (2016-03-01 13:56:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dbaf47de5e9de11f894cc85629b5f394779bf78f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698