Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1747203002: Add missing DevToolsEmulator field initialization. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing DevToolsEmulator field initialization. Introduced in r371567. R= BUG=581115 Committed: https://crrev.com/6f0b265ae2d4b84b1b93ea5b96ad2d6c14529bb3 Cr-Commit-Position: refs/heads/master@{#378491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. Causes visual viewport unit test failures (non-Oilpan), https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan%20%28dbg%29/builds/231/steps/webkit_unit_tests%20on%20Windows-7-SP1 (Oilpan guarantees that ...
4 years, 9 months ago (2016-03-01 12:18:57 UTC) #2
dgozman
lgtm Thank you for fixing this! I guess we should also merge this to M50, ...
4 years, 9 months ago (2016-03-01 18:27:42 UTC) #3
sof
On 2016/03/01 18:27:42, dgozman wrote: > lgtm > > Thank you for fixing this! I ...
4 years, 9 months ago (2016-03-01 18:36:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747203002/1
4 years, 9 months ago (2016-03-01 18:37:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 18:45:37 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 18:46:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f0b265ae2d4b84b1b93ea5b96ad2d6c14529bb3
Cr-Commit-Position: refs/heads/master@{#378491}

Powered by Google App Engine
This is Rietveld 408576698