Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 17472007: [Telemetry] Expose v8's window.gc() method to the PerfTestRunner. (Closed)

Created:
7 years, 6 months ago by tonyg
Modified:
7 years, 6 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

[Telemetry] Expose v8's window.gc() method to the PerfTestRunner. Blink's PerfTestRunner has a gc method which tries to call window.GCController.collect(), if it doesn't exist, it allocates a whole bunch of memory to try to trigger a gc. Since the blink_perf Measurement already passes --js-flags=--expose_gc, we can call the window.gc() method instead of this hackery. I'm hopeful that this will fix the Bindings/gc-tree.html crashes on android. BUG=252897 R=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/perf/perf_tools/blink_perf.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
7 years, 6 months ago (2013-06-21 21:42:36 UTC) #1
dtu
Why all this when tab has a tab.CollectGarbage() method?
7 years, 6 months ago (2013-06-21 21:57:45 UTC) #2
tonyg
On 2013/06/21 21:57:45, Dave Tu wrote: > Why all this when tab has a tab.CollectGarbage() ...
7 years, 6 months ago (2013-06-21 22:04:52 UTC) #3
dtu
lgtm
7 years, 6 months ago (2013-06-21 22:28:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/17472007/1
7 years, 6 months ago (2013-06-21 22:38:29 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-22 00:04:49 UTC) #6
tonyg
7 years, 6 months ago (2013-06-22 00:36:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r207975 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698