Move webkit_resources / webkit_strings targets out of webkit_support.gyp

Move webkit_resources / webkit_strings targets out of webkit_support.gyp

The webkit_resources / webkit_strings targets were defined in webkit_glue.gypi
which gets pulled in to webkit/support/webkit_support.gyp. This makes it hard to
extract other targets that depend on these (such as webkit_common) out of
webkit_support.gyp without creating cycles between gyp files, which is forbidden
due to the xcode generator.  This pulls these leaf targets out so we can start
extracting other targets out.

R=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210080

[jamesr, 2013-06-21 20:53:31]

This depends on:
https://codereview.chromium.org/17029016/ (to remove need for
DumpRenderTree_resources target)
https://codereview.chromium.org/17320012/ (to remove DumpRenderTree_resources
target, which depends on webkit_(resources|strings) from the Blink repository)

[darin (slow to review), 2013-06-21 20:58:46]

LGTM

[jamesr, 2013-06-26 23:41:22]

Turns out we can't remove the blink reference to the resources, at least not
yet.  We also can't have more than one target called 'webkit_resources' in the
tree, so this creates webkit_temp_resources / webkit_temp_strings.  Plan is
thus:

1.) Land this, with all chromium code depending on
webkit/webkit_resources.gyp:webkit_temp_(resources|strings) and forwarding
targets webkit/support/webkit_support.gyp:webkit_(resources|strings) for DRT.
2.) In blink, update references to
webkit/webkit_resources.gyp:webkit_temp_(resources|strings)
3.) Wait for blink roll
4.) Update chromium code to point at
webkit/webkit_resources.gyp:webkit_(resources|strings) and leave
webkit/webkit.resources.gyp:webkit_temp_(resources|strings) as forwarding
targets for DRT
5.) In blink, redirect to actual resources|strings targets
6.) Wait for blink roll
7.) Delete webkit_temp_(resources|strings)

Bleh!

PTAL

[darin (slow to review), 2013-06-26 23:47:23]

LGTM

[commit-bot: I haz the power, 2013-06-26 23:47:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/5001

[commit-bot: I haz the power, 2013-06-27 00:17:06]

Retried try job too often on win7_aura for step(s) ash_unittests,
aura_unittests, browser_tests, compositor_unittests, content_browsertests,
content_unittests, interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-06-27 04:34:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/25001

[commit-bot: I haz the power, 2013-06-27 07:12:47]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-27 17:07:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/25001

[commit-bot: I haz the power, 2013-06-27 17:07:07]

Failed to apply patch for webkit/common/webkit_common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file webkit/common/webkit_common.gypi
  Hunk #1 FAILED at 20.
  1 out of 1 hunk FAILED -- saving rejects to file
webkit/common/webkit_common.gypi.rej

Patch:       webkit/common/webkit_common.gypi
Index: webkit/common/webkit_common.gypi
diff --git a/webkit/common/webkit_common.gypi b/webkit/common/webkit_common.gypi
index
353efaf5930e42246ea2b0606186ce79eea50480..e2820d3bd1c6557b82b8ff5d6ec7c3bab1db43f9
100644
--- a/webkit/common/webkit_common.gypi
+++ b/webkit/common/webkit_common.gypi
@@ -20,7 +20,7 @@
         '<(DEPTH)/ui/ui.gyp:ui',
         '<(DEPTH)/ui/ui.gyp:ui_resources',
         '<(DEPTH)/url/url.gyp:url_lib',
-        'webkit_resources',
+        '<(DEPTH)/webkit/webkit_resources.gyp:webkit_temp_resources',
       ],
 
       'include_dirs': [

[commit-bot: I haz the power, 2013-06-27 17:33:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/38001

[commit-bot: I haz the power, 2013-06-27 17:42:59]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-27 19:33:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/60001

[commit-bot: I haz the power, 2013-06-27 22:15:39]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-07-03 20:10:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17472006/60001

[commit-bot: I haz the power, 2013-07-04 00:20:06]

Change committed as 210080