Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1747173002: nanobench: Use device independent font flag for GPU configs (Closed)

Created:
4 years, 9 months ago by Kimmo Kinnunen
Modified:
4 years, 9 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nanobench: Use device independent font flag for GPU configs Actually use the device independent font flag that the user passes via "--config 'gpu(dit=true,...)'" GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747173002 Committed: https://skia.googlesource.com/skia/+/d4e1c351150437ee5eaf364533191b28fcfcc410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M bench/nanobench.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Kimmo Kinnunen
4 years, 9 months ago (2016-03-01 07:10:22 UTC) #3
mtklein
Seems fine to me. I'm not really familiar with this code. Is there a better ...
4 years, 9 months ago (2016-03-01 13:42:51 UTC) #4
Kimmo Kinnunen
Hopefully Brian?
4 years, 9 months ago (2016-03-01 19:07:37 UTC) #6
bsalomon
lgtm
4 years, 9 months ago (2016-03-01 20:10:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747173002/1
4 years, 9 months ago (2016-03-02 07:28:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d4e1c351150437ee5eaf364533191b28fcfcc410
4 years, 9 months ago (2016-03-02 07:41:30 UTC) #11
jcgregorio
On 2016/03/02 at 07:41:30, commit-bot wrote: > Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d4e1c351150437ee5eaf364533191b28fcfcc410 Was this ...
4 years, 9 months ago (2016-03-03 18:59:03 UTC) #12
Kimmo Kinnunen
4 years, 9 months ago (2016-03-04 05:49:00 UTC) #13
Message was sent while issue was closed.
On 2016/03/03 18:59:03, jcgregorio wrote:
> On 2016/03/02 at 07:41:30, commit-bot wrote:
> > Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/d4e1c351150437ee5eaf364533191b28fcfcc410
> 
> Was this CL expected to slow down GPU Android tests, in particular nvprmsaa4?
> 
>   https://perf.skia.org/#4946

Yeah, that is as expected. I did not remember the gotcha or have insight to
write that to the commit msg, but that's what should happen.
THe nvprmsaa4 and nvprmsaa16 backends have "use device independent fonts"
setting on, and that was previously ignored by nanobench. Thanks for verifying.

Powered by Google App Engine
This is Rietveld 408576698