Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1747143002: Remove WebContents::WasHidden() calls in chrome::AddRestoredTab() and TabLoader

Created:
4 years, 9 months ago by tapted
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebContents::WasHidden() calls in chrome::AddRestoredTab() and TabLoader Currently session restore does: 1. Create a tab with WebContents::CreateParams::initially_hidden=true 2. Call WebContents::WasHidden in chrome::AddRestoredTab(), even though it was never shown 3. Call WebContents::WasHidden a second time in TabLoader::LoadNextTab(), after asking the NavigationController to LoadIfNecessary() The calls are unbalanced, and violate a comment in RenderWidgetHostView, saying "It is not legal to call Hide() multiple times in a row." AddRestoredTab doesn't need to call WasHidden because it derives a value for WebContents::CreateParams::initially_hidden from its |select| argument. BUG=590981

Patch Set 1 #

Patch Set 2 : checking does not work - no RWHV #

Patch Set 3 : Also remove from TabLoader, fix RenderWidgetHostViewMac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/browser/sessions/tab_loader.cc View 1 2 1 chunk +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
tapted
Description was changed from ========== Remove the call to WebContents::WasHidden() in chrome::AddRestoredTab() BUG= ========== to ...
4 years, 9 months ago (2016-03-01 05:51:24 UTC) #1
tapted
Description was changed from ========== Remove WebContents::WasHidden() calls in chrome::AddRestoredTab() and TabLoader Currently session restore ...
4 years, 9 months ago (2016-03-01 06:48:30 UTC) #2
tapted
4 years, 9 months ago (2016-03-01 08:40:06 UTC) #3 
Description was changed from

==========
Remove WebContents::WasHidden() calls in chrome::AddRestoredTab() and TabLoader

Currently session restore does:

1. Create a tab with WebContents::CreateParams::initially_hidden=true

2. Call WebContents::WasHidden in chrome::AddRestoredTab(), even though
it was never shown

3. Call WebContents::WasHidden a second time in
TabLoader::LoadNextTab(), after asking the NavigationController to
LoadIfNecessary()

The calls are unbalanced, and violate a comment in RenderWidgetHostView,
saying "It is not legal to call Hide() multiple times in a row."

BUG=590981
==========

to

==========
Remove WebContents::WasHidden() calls in chrome::AddRestoredTab() and TabLoader

Currently session restore does:

1. Create a tab with WebContents::CreateParams::initially_hidden=true

2. Call WebContents::WasHidden in chrome::AddRestoredTab(), even though
it was never shown

3. Call WebContents::WasHidden a second time in
TabLoader::LoadNextTab(), after asking the NavigationController to
LoadIfNecessary()

The calls are unbalanced, and violate a comment in RenderWidgetHostView,
saying "It is not legal to call Hide() multiple times in a row."

AddRestoredTab doesn't need to call WasHidden because it derives a value
for WebContents::CreateParams::initially_hidden from its |select|
argument.

BUG=590981
==========

Powered by Google App Engine
This is Rietveld 408576698