core/include/fpdfapi/fpdf_resource.h - Issue 1747123002: Fix and enable lint checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_resource.h

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_resource.h

diff --git a/core/include/fpdfapi/fpdf_resource.h b/core/include/fpdfapi/fpdf_resource.h

index 23e1b55efb82a5162e1ae521700e6d5410dac75f..97c9c40d741dbcd5dd9dcb6583a8434e3a237b3e 100644

--- a/core/include/fpdfapi/fpdf_resource.h

+++ b/core/include/fpdfapi/fpdf_resource.h

@@ -166,7 +166,7 @@ class CPDF_Font {

CFX_ByteString*& pCharNames,

FX_BOOL bEmbedded,

FX_BOOL bTrueType);

- void LoadFontDescriptor(CPDF_Dictionary*);

+ void LoadFontDescriptor(CPDF_Dictionary* dict);

Tom Sepez 2016/03/01 17:38:05 nit: |pDict| just to be consistent.

dsinclair 2016/03/01 18:11:51 Done.

void CheckFontMetrics();

CFX_ByteString m_BaseFont;