Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: xfa/src/fdp/src/css/fde_cssdeclaration.cpp

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/src/fdp/src/css/fde_cssdeclaration.h" 7 #include "xfa/src/fdp/src/css/fde_cssdeclaration.h"
8 8
9 #include "core/include/fxcrt/fx_ext.h" 9 #include "core/include/fxcrt/fx_ext.h"
10 #include "xfa/src/fgas/include/fx_sys.h" 10 #include "xfa/src/fgas/include/fx_sys.h"
(...skipping 914 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 pPosX = NewEnumValue(pStaticStore, pValue->eName); 925 pPosX = NewEnumValue(pStaticStore, pValue->eName);
926 } 926 }
927 break; 927 break;
928 default: 928 default:
929 break; 929 break;
930 } 930 }
931 break; 931 break;
932 } 932 }
933 const FDE_CSSCOLORTABLE* pColorItem = 933 const FDE_CSSCOLORTABLE* pColorItem =
934 FDE_GetCSSColorByName(pszValue, iValueLen); 934 FDE_GetCSSColorByName(pszValue, iValueLen);
935 if (pColorItem != NULL) 935 if (pColorItem != NULL) {
936 if (pColor == NULL) { 936 if (pColor == NULL) {
937 pColor = FXTARGET_NewWith(pStaticStore) 937 pColor = FXTARGET_NewWith(pStaticStore)
938 CFDE_CSSPrimitiveValue(pColorItem->dwValue); 938 CFDE_CSSPrimitiveValue(pColorItem->dwValue);
939 } 939 }
940 }
940 } break; 941 } break;
941 case FDE_CSSPRIMITIVETYPE_RGB: 942 case FDE_CSSPRIMITIVETYPE_RGB:
942 if (pColor == NULL) { 943 if (pColor == NULL) {
943 FX_ARGB dwColor; 944 FX_ARGB dwColor;
944 if (FDE_ParseCSSColor(pszValue, iValueLen, dwColor)) { 945 if (FDE_ParseCSSColor(pszValue, iValueLen, dwColor)) {
945 pColor = 946 pColor =
946 FXTARGET_NewWith(pStaticStore) CFDE_CSSPrimitiveValue(dwColor); 947 FXTARGET_NewWith(pStaticStore) CFDE_CSSPrimitiveValue(dwColor);
947 } 948 }
948 } 949 }
949 break; 950 break;
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
1367 return FALSE; 1368 return FALSE;
1368 } else if (pOverflowY == NULL) { 1369 } else if (pOverflowY == NULL) {
1369 pOverflowY = NewEnumValue(pStaticStore, pOverflowX->GetEnum()); 1370 pOverflowY = NewEnumValue(pStaticStore, pOverflowX->GetEnum());
1370 } 1371 }
1371 AddPropertyHolder(pStaticStore, FDE_CSSPROPERTY_OverflowX, pOverflowX, 1372 AddPropertyHolder(pStaticStore, FDE_CSSPROPERTY_OverflowX, pOverflowX,
1372 bImportant); 1373 bImportant);
1373 AddPropertyHolder(pStaticStore, FDE_CSSPROPERTY_OverflowY, pOverflowY, 1374 AddPropertyHolder(pStaticStore, FDE_CSSPROPERTY_OverflowY, pOverflowY,
1374 bImportant); 1375 bImportant);
1375 return TRUE; 1376 return TRUE;
1376 } 1377 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698