Rework compositor touch hit testing

Source/core/rendering/RenderBlock.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 550 matching lines @@
 protected:
     virtual void addOverflowFromChildren();
     void addOverflowFromFloats();
     void addOverflowFromPositionedObjects();
     void addOverflowFromBlockChildren();
     void addOverflowFromInlineChildren();
     void addVisualOverflowFromTheme();
 
     virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& additionalOffset, const RenderLayerModelObject* paintContainer = 0) OVERRIDE;
 
+    virtual void computeOwnHitTestRects(Vector<IntRect>&, const LayoutPoint& layerOffset) const OVERRIDE;

[leviw_travelin_and_unemployed, 2013/07/18 18:08:39]

"Own" seems redundant to me.

[Rick Byers, 2013/07/18 19:58:52]

I wanted to clearly differentiate it from the public entrypoint
'computeLayerHitTestRects' which computes the rects for this node and all it's
children. computeHitTestRects seems ambiguous to me as to whether it's a single
node or a tree walk.

What about: one of these pairs of names?
computeHitTestsRectsForTree / computeHitTestsRectsForRenderer
or
computeTreeHitTestRects / computeSelfHitTestRects

[leviw_travelin_and_unemployed, 2013/07/18 20:21:48]

I like computeSelfHitTestRects

[Rick Byers, 2013/07/18 22:20:32]

Done.

+
     // Only used by RenderSVGText, which explicitly overrides RenderBlock::layoutBlock(), do NOT use for anything else.
     void forceLayoutInlineChildren()
     {
         LayoutUnit repaintLogicalTop = 0;
         LayoutUnit repaintLogicalBottom = 0;
         clearFloats();
         layoutInlineChildren(true, repaintLogicalTop, repaintLogicalBottom);
     }
 
     bool updateRegionsAndShapesLogicalSize(RenderFlowThread*);
@@ skipping 762 matching lines @@
     static String string(const int value);
 };
 template<> struct ValueToString<RenderBlock::FloatingObject*> {
     static String string(const RenderBlock::FloatingObject*);
 };
 #endif
 
 } // namespace WebCore
 
 #endif // RenderBlock_h