Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 17471008: Rework compositor touch hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: CR feedback - accumulate LayoutRects instead of IntRects, disable when page isn't composited. Also… Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 32
33 #include "core/rendering/svg/RenderSVGModelObject.h" 33 #include "core/rendering/svg/RenderSVGModelObject.h"
34 34
35 #include "SVGNames.h" 35 #include "SVGNames.h"
36 #include "core/rendering/svg/RenderSVGRoot.h"
36 #include "core/rendering/svg/SVGResourcesCache.h" 37 #include "core/rendering/svg/SVGResourcesCache.h"
37 #include "core/svg/SVGStyledElement.h" 38 #include "core/svg/SVGStyledElement.h"
38 39
39 namespace WebCore { 40 namespace WebCore {
40 41
41 RenderSVGModelObject::RenderSVGModelObject(SVGStyledElement* node) 42 RenderSVGModelObject::RenderSVGModelObject(SVGStyledElement* node)
42 : RenderObject(node) 43 : RenderObject(node)
43 , m_hasSVGShadow(false) 44 , m_hasSVGShadow(false)
44 { 45 {
45 } 46 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 { 88 {
88 quads.append(localToAbsoluteQuad(strokeBoundingBox(), 0 /* mode */, wasFixed )); 89 quads.append(localToAbsoluteQuad(strokeBoundingBox(), 0 /* mode */, wasFixed ));
89 } 90 }
90 91
91 void RenderSVGModelObject::willBeDestroyed() 92 void RenderSVGModelObject::willBeDestroyed()
92 { 93 {
93 SVGResourcesCache::clientDestroyed(this); 94 SVGResourcesCache::clientDestroyed(this);
94 RenderObject::willBeDestroyed(); 95 RenderObject::willBeDestroyed();
95 } 96 }
96 97
98 void RenderSVGModelObject::computeLayerHitTestRects(LayerHitTestRects& rects) co nst
99 {
100 // Using just the rect for the SVGRoot is good enough for now.
101 SVGRenderSupport::findTreeRootObject(this)->computeLayerHitTestRects(rects);
102 }
103
104 void RenderSVGModelObject::addLayerHitTestRects(LayerHitTestRects&, const Render Layer* currentLayer, const LayoutPoint& layerOffset) const
105 {
106 // We don't walk into SVG trees at all - just report their container.
107 }
108
97 void RenderSVGModelObject::styleWillChange(StyleDifference diff, const RenderSty le* newStyle) 109 void RenderSVGModelObject::styleWillChange(StyleDifference diff, const RenderSty le* newStyle)
98 { 110 {
99 if (diff == StyleDifferenceLayout) { 111 if (diff == StyleDifferenceLayout) {
100 setNeedsBoundariesUpdate(); 112 setNeedsBoundariesUpdate();
101 if (newStyle->hasTransform()) 113 if (newStyle->hasTransform())
102 setNeedsTransformUpdate(); 114 setNeedsTransformUpdate();
103 } 115 }
104 RenderObject::styleWillChange(diff, newStyle); 116 RenderObject::styleWillChange(diff, newStyle);
105 } 117 }
106 118
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 if (!isGraphicsElement(renderer)) 202 if (!isGraphicsElement(renderer))
191 return false; 203 return false;
192 AffineTransform ctm; 204 AffineTransform ctm;
193 SVGElement* svgElement = toSVGElement(renderer->node()); 205 SVGElement* svgElement = toSVGElement(renderer->node());
194 getElementCTM(svgElement, ctm); 206 getElementCTM(svgElement, ctm);
195 ASSERT(svgElement->renderer()); 207 ASSERT(svgElement->renderer());
196 return rect.contains(ctm.mapRect(svgElement->renderer()->repaintRectInLocalC oordinates())); 208 return rect.contains(ctm.mapRect(svgElement->renderer()->repaintRectInLocalC oordinates()));
197 } 209 }
198 210
199 } // namespace WebCore 211 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698