LayoutTests/fast/events/touch/compositor-touch-hit-rects-iframes.html - Issue 17471008: Rework compositor touch hit testing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/compositor-touch-hit-rects-iframes.html

Issue 17471008: Rework compositor touch hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: CR feedback - accumulate LayoutRects instead of IntRects, disable when page isn't composited. Also… Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt ('k') | LayoutTests/fast/events/touch/compositor-touch-hit-rects-iframes-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="stylesheet" href="resources/compositor-touch-hit-rects.css">

	5 <style>

	6 iframe {

	7 height: 25px;

	8 width: 400px;

	9 overflow-x: hidden;

	10 }

	11 #iframe-nested {

	12 height: 35px;

	13 }

	14 #iframe-transform {

	15 -webkit-transform: scale(1.1) rotate(1grad);

	16 margin: 10px 30px;

	17 }

	18 </style>

	19 </head>

	20 <body>

	21 <p id="description">

	22 This tests verifies the hit test regions given to the compositor when non-compos ited iframes are involved.

	23 It can only be run in DumpRenderTree. The outputted rects should cover the hit test regions of all the listed elements. Enable visualize mode to quickly valid ate graphically.</p>

	24

	25 <div id="tests">

	26 <iframe id="iframe" src="resources/compositor-touch-hit-rects-iframe.html"></i frame>

	27 <iframe id="iframe-nested" src="resources/compositor-touch-hit-rects-iframe-ne sted.html"></iframe>

	28 <iframe id="iframe-transform" src="resources/compositor-touch-hit-rects-iframe .html"></iframe>

	29 <iframe id="iframe-doc" src="resources/compositor-touch-hit-rects-iframe-doc.h tml"></iframe>

	30 </div>

	31

	32 <div id="console"></div>

	33 <script src="resources/compositor-touch-hit-rects.js"></script>

	34 <script>

	35 function runIFrameTest(id) {

	36 var elem = document.getElementById(id);

	37 if (!elem.addHandlers) {

	38 log('FAIL - child iframe has not setup handlers in parent.');

	39 return;

	40 }

	41

	42 elem.addHandlers();

	43 logRects(id);

	44 elem.removeHandlers();

	45 }

	46 function additionalTests() {

	47 runIFrameTest('iframe');

	48 runIFrameTest('iframe-nested');

	49 runIFrameTest('iframe-transform');

	50 runIFrameTest('iframe-doc');

	51 }

	52 </script>

	53 </body>

OLD	NEW