Move PEM certificate decoding to onc_utils.

Move PEM certificate decoding to onc_utils.

This prepares usage of the decoding in NetworkLibrary.
While there, removed redundant namespace qualifiers from onc_utils.*.

BUG=208986
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207861

[pneubeck (no reviews), 2013-06-20 15:45:03]

Separated from the larger CL https://codereview.chromium.org/16946002/.

Please review this one. Thanks!

[Mattias Nissler (ping if slow), 2013-06-20 16:15:35]

LGTM w/ nits

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
File chromeos/network/onc/onc_utils.cc (right):

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
chromeos/network/onc/onc_utils.cc:350: namespace {
By convention, this should be at the top of the file, or just declare the
constants as static strings within the function.

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
File chromeos/network/onc/onc_utils.h (right):

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
chromeos/network/onc/onc_utils.h:93: CHROMEOS_EXPORT
scoped_refptr<net::X509Certificate> GetCertFromPEMEncoding(
nit: Maybe DecodePEMCertificate would be a more accurate name? Your call.

[pneubeck (no reviews), 2013-06-21 11:28:00]

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
File chromeos/network/onc/onc_utils.cc (right):

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
chromeos/network/onc/onc_utils.cc:350: namespace {
On 2013/06/20 16:15:36, Mattias Nissler wrote:
> By convention, this should be at the top of the file, or just declare the
> constants as static strings within the function.

Done.

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
File chromeos/network/onc/onc_utils.h (right):

https://codereview.chromium.org/17471005/diff/4001/chromeos/network/onc/onc_u...
chromeos/network/onc/onc_utils.h:93: CHROMEOS_EXPORT
scoped_refptr<net::X509Certificate> GetCertFromPEMEncoding(
On 2013/06/20 16:15:36, Mattias Nissler wrote:
> nit: Maybe DecodePEMCertificate would be a more accurate name? Your call.

Done.

[commit-bot: I haz the power, 2013-06-21 11:29:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/17471005/12001

[commit-bot: I haz the power, 2013-06-21 12:06:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-21 13:21:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/17471005/28002

[commit-bot: I haz the power, 2013-06-21 16:42:20]

Change committed as 207861