EME on Android: Improve accuracy of Key System availability.

EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236, 582618
Committed: https://crrev.com/f1f20728a18fff332af52c0e60726a8b34510ba6
Cr-Commit-Position: refs/heads/master@{#378959}

[ddorwin, 2016-03-01 01:25:08]

Description was changed from

==========
EME on Android: Improve accuracy of Key System availability.

BUG=559236,582618
==========

to

==========
EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236,582618
==========

[ddorwin, 2016-03-01 01:26:04]

ddorwin@chromium.org changed reviewers:
+ xhwang@chromium.org

[ddorwin, 2016-03-01 01:26:04]

I implemented what I wrote in https://crbug.com/582618#c7. I'm interested in
general feedback for now, though feel free to do a detailed review.

[xhwang, 2016-03-02 06:57:08]

I did end up doing a full review :) Sorry for the delay.

LGTM with nits.

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/base/android/m...
File media/base/android/media_drm_bridge.cc (right):

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/base/android/m...
media/base/android/media_drm_bridge.cc:247: return
MediaCodecUtil::IsMediaCodecAvailable();
nit: how about:

return AreMediaDrmApisAvailable() && MediaCodecUtil::IsMediaCodecAvailable();

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/blink/key_syst...
File media/blink/key_system_config_selector.cc (right):

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/blink/key_syst...
media/blink/key_system_config_selector.cc:291: codec_vector);
drop media:: here and everywhere else since we are already in media namespace?

[ddorwin, 2016-03-02 21:11:53]

ddorwin@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[ddorwin, 2016-03-02 21:11:54]

dalecurtis: PTAL at everything except media/base/android/* as this modifies the
logic you recently added.

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/base/android/m...
File media/base/android/media_drm_bridge.cc (right):

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/base/android/m...
media/base/android/media_drm_bridge.cc:247: return
MediaCodecUtil::IsMediaCodecAvailable();
On 2016/03/02 06:57:08, xhwang wrote:
> nit: how about:
> 
> return AreMediaDrmApisAvailable() && MediaCodecUtil::IsMediaCodecAvailable();

Done.

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/blink/key_syst...
File media/blink/key_system_config_selector.cc (right):

https://chromiumcodereview.appspot.com/1747073003/diff/1/media/blink/key_syst...
media/blink/key_system_config_selector.cc:291: codec_vector);
On 2016/03/02 06:57:08, xhwang wrote:
> drop media:: here and everywhere else since we are already in media namespace?

Done.

[DaleCurtis, 2016-03-03 00:08:06]

lgtm % up to you nit.

https://chromiumcodereview.appspot.com/1747073003/diff/20001/media/base/media.h
File media/base/media.h (right):

https://chromiumcodereview.appspot.com/1747073003/diff/20001/media/base/media...
media/base/media.h:50: // Returns whether the platform decoders are available
for use.
Comment nit: Reflow lines so you use all 80 characters.

[ddorwin, 2016-03-03 00:13:55]

Thanks.

https://chromiumcodereview.appspot.com/1747073003/diff/20001/media/base/media.h
File media/base/media.h (right):

https://chromiumcodereview.appspot.com/1747073003/diff/20001/media/base/media...
media/base/media.h:50: // Returns whether the platform decoders are available
for use.
On 2016/03/03 00:08:06, DaleCurtis wrote:
> Comment nit: Reflow lines so you use all 80 characters.

I like this as a one line description with details below, like a commit message.
(Granted, that's not the pattern in this file.) I don't think reflowing saves
any vertical space, so I think I'll just leave it.

[ddorwin, 2016-03-03 00:14:02]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2016-03-03 00:14:02]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1747073003/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2016-03-03 00:15:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747073003/20001

[commit-bot: I haz the power, 2016-03-03 02:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 02:08:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ddorwin, 2016-03-03 04:20:18]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-03-03 04:20:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747073003/20001

[commit-bot: I haz the power, 2016-03-03 05:06:39]

Description was changed from

==========
EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236,582618
==========

to

==========
EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236,582618
==========

[commit-bot: I haz the power, 2016-03-03 05:06:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 05:07:58]

Description was changed from

==========
EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236,582618
==========

to

==========
EME on Android: Improve accuracy of Key System availability.

Implemented per https://crbug.com/582618#c7.

BUG=559236,582618

Committed: https://crrev.com/f1f20728a18fff332af52c0e60726a8b34510ba6
Cr-Commit-Position: refs/heads/master@{#378959}
==========

[commit-bot: I haz the power, 2016-03-03 05:07:59]

Patchset 2 (id:??) landed as
https://crrev.com/f1f20728a18fff332af52c0e60726a8b34510ba6
Cr-Commit-Position: refs/heads/master@{#378959}