Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1747053003: Reland: Bootstrap Mojo IPC independent of Chrome IPC (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Bootstrap Mojo IPC independent of Chrome IPC The original CL: https://crrev.com/eb199fbaecd8e5d294010dfbe8897b7d83aeab07 broke NaCL integration tests on some bots. After some extensive investigation this is somehow tied to an obscure dependency on the value of kIPCDescriptorMax. Moving kMojoIPCChannel to content_descriptors.h allows us to avoid changing that value and thus avoid the mysterious breakage. :| Original CL description follows: This initializes Mojo IPC very early in child process startup so we can start using cross-process pipes in content without a dependency on Chrome IPC. On all supported platforms, a new OS pipe handle is passed through ChildProcessLauncher and hooked up to the EDK on ChildThreadImpl startup to establish a Mojo IPC channel to the parent. A command-line argument is also to used to share a unique pipe token with the child, and this token is exchanged over the Mojo IPC channel to bootstrap a primordial message pipe. While this CL establishes these facilities in a way that can be used for all child processes, only render processes are brought up in this way for now. BUG=583557 TEST=Chrome still runs in mash with Mus-in-renderer support. TBR=ben@chromium.org,jschuh@chromium.org Committed: https://crrev.com/e8b8da4b8f513b7ab03bb2e2eb9156bc828267a5 Cr-Commit-Position: refs/heads/master@{#378704}

Patch Set 1 #

Patch Set 2 : Move descriptor enum from ipc to content #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -127 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/child_process_launcher.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/child_process_launcher.cc View 12 chunks +34 lines, -5 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.h View 2 chunks +9 lines, -7 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 7 chunks +19 lines, -62 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +6 lines, -14 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 6 chunks +33 lines, -26 lines 0 comments Download
M content/common/mojo/mojo_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_descriptors.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/zygote_fork_delegate_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747053003/1
4 years, 9 months ago (2016-03-01 16:53:58 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 18:12:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747053003/20001
4 years, 9 months ago (2016-03-02 04:52:36 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 06:07:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747053003/20001
4 years, 9 months ago (2016-03-02 06:13:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 06:20:34 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 06:21:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8b8da4b8f513b7ab03bb2e2eb9156bc828267a5
Cr-Commit-Position: refs/heads/master@{#378704}

Powered by Google App Engine
This is Rietveld 408576698