Revert of Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a Reque…

Revert of Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* (patchset #11 id:200001 of https://codereview.chromium.org/1439053002/ )

Reason for revert:
Top crasher on Canary has PAC script cancellation on callstack. Very likely a bug or interaction with this CL.

Reverting until I have a chance to fully investigate.

Original issue's description:
> Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle*
>
> * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*|
>   rather than a |void*|
> * ProxyResolver::CancelRequest(void*) has been removed. Requests
>   are instead cancelled by resetting the scoped_ptr<Request>.
>
> This makes for less error prone code as cancellation of
> requests is automatic when the
> scoped_ptr<Request> goes out of scope.
> ProxyResolver::GetLoadState() is removed and replaced
> by Request::GetLoadState().
>
> Also made some renaming, as there were similar class
> named Job or Request. Now they are all Job and this new thing
> is Request.
>
> Referencing by address to object in vector was not wise in net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using scoped_ptrs in that vector.
>
> BUG=478934
>
> Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069
> Cr-Commit-Position: refs/heads/master@{#377856}

TBR=davidben@chromium.org,olli.raula@intel.com
BUG=478934
Review URL: https://codereview.chromium.org/1745133002

Cr-Commit-Position: refs/heads/master@{#378274}
(cherry picked from commit 9c8f42482a36ed8f614e1ae35eb137300cdbe6eb)

Committed: https://chromium.googlesource.com/chromium/src/+/4c6ac2e78a90356f0a304b7126ecc050d3a07f1f

[eroman, 2016-02-29 22:26:12]

Description was changed from

==========
Revert of Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>*
rather than a RequestHandle* (patchset #11 id:200001 of
https://codereview.chromium.org/1439053002/ )

Reason for revert:
Top crasher on Canary has PAC script cancellation on callstack. Very likely a
bug or interaction with this CL.

Reverting until I have a chance to fully investigate.

Original issue's description:
> Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather
than a RequestHandle*
>
> * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*|
>   rather than a |void*|
> * ProxyResolver::CancelRequest(void*) has been removed. Requests
>   are instead cancelled by resetting the scoped_ptr<Request>.
>
> This makes for less error prone code as cancellation of
> requests is automatic when the
> scoped_ptr<Request> goes out of scope.
> ProxyResolver::GetLoadState() is removed and replaced
> by Request::GetLoadState().
>
> Also made some renaming, as there were similar class
> named Job or Request. Now they are all Job and this new thing
> is Request.
>
> Referencing by address to object in vector was not wise in
net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using
scoped_ptrs in that vector.
>
> BUG=478934
>
> Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069
> Cr-Commit-Position: refs/heads/master@{#377856}

TBR=davidben@chromium.org,olli.raula@intel.com
BUG=478934

Review URL: https://codereview.chromium.org/1745133002

Cr-Commit-Position: refs/heads/master@{#378274}
(cherry picked from commit 9c8f42482a36ed8f614e1ae35eb137300cdbe6eb)
==========

to

==========
Revert of Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>*
rather than a RequestHandle* (patchset #11 id:200001 of
https://codereview.chromium.org/1439053002/ )

Reason for revert:
Top crasher on Canary has PAC script cancellation on callstack. Very likely a
bug or interaction with this CL.

Reverting until I have a chance to fully investigate.

Original issue's description:
> Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather
than a RequestHandle*
>
> * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*|
>   rather than a |void*|
> * ProxyResolver::CancelRequest(void*) has been removed. Requests
>   are instead cancelled by resetting the scoped_ptr<Request>.
>
> This makes for less error prone code as cancellation of
> requests is automatic when the
> scoped_ptr<Request> goes out of scope.
> ProxyResolver::GetLoadState() is removed and replaced
> by Request::GetLoadState().
>
> Also made some renaming, as there were similar class
> named Job or Request. Now they are all Job and this new thing
> is Request.
>
> Referencing by address to object in vector was not wise in
net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using
scoped_ptrs in that vector.
>
> BUG=478934
>
> Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069
> Cr-Commit-Position: refs/heads/master@{#377856}

TBR=davidben@chromium.org,olli.raula@intel.com
BUG=478934

Review URL: https://codereview.chromium.org/1745133002

Cr-Commit-Position: refs/heads/master@{#378274}
(cherry picked from commit 9c8f42482a36ed8f614e1ae35eb137300cdbe6eb)

Committed:
https://chromium.googlesource.com/chromium/src/+/4c6ac2e78a90356f0a304b7126ec...
==========

[eroman, 2016-02-29 22:26:14]

Committed patchset #1 (id:1) manually as
4c6ac2e78a90356f0a304b7126ecc050d3a07f1f.

[Olli Raula, 2016-02-29 22:26:24]

I am not working here anymore, to contact me, email to firstname@lastname.org