Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1746993002: Stop chrome from logging profile counts too many times at startup. (Closed)

Created:
4 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
4 years, 7 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop chrome from logging profile counts too many times at startup. BUG=580127 Committed: https://crrev.com/fab2d8a1f92ceb454d3501014e0b323b63e03704 Cr-Commit-Position: refs/heads/master@{#386132} Committed: https://crrev.com/f9a87728113bccfac096b340f59a03f877327359 Cr-Commit-Position: refs/heads/master@{#390143}

Patch Set 1 #

Patch Set 2 : Add profile manager change #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : rebased #

Patch Set 8 : rebased #

Patch Set 9 : for sync #

Patch Set 10 : rebased #

Patch Set 11 : rebased #

Patch Set 12 : rebased #

Patch Set 13 : rebased #

Patch Set 14 : rebased #

Patch Set 15 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/profiles/gaia_info_update_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 29 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746993002/20001
4 years, 9 months ago (2016-03-01 22:17:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 00:47:28 UTC) #4
Roger Tawa OOO till Jul 10th
Hi Anthony, Change to reduce duplicate uma logging. Same as before. If possible, would be ...
4 years, 9 months ago (2016-03-02 16:30:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746993002/40001
4 years, 9 months ago (2016-03-02 18:40:07 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 18:46:36 UTC) #10
anthonyvd
lgtm
4 years, 9 months ago (2016-03-04 15:10:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746993002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746993002/180001
4 years, 8 months ago (2016-04-08 17:53:36 UTC) #15
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 8 months ago (2016-04-08 18:38:16 UTC) #16
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/fab2d8a1f92ceb454d3501014e0b323b63e03704 Cr-Commit-Position: refs/heads/master@{#386132}
4 years, 8 months ago (2016-04-08 18:39:31 UTC) #18
nednguyen
A revert of this CL (patchset #10 id:180001) has been created in https://codereview.chromium.org/1874353002/ by nednguyen@google.com. ...
4 years, 8 months ago (2016-04-11 16:07:04 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746993002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746993002/180001
4 years, 8 months ago (2016-04-20 21:15:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746993002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746993002/280001
4 years, 7 months ago (2016-04-27 18:13:06 UTC) #25
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 7 months ago (2016-04-27 19:07:22 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:44 UTC) #28
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/f9a87728113bccfac096b340f59a03f877327359
Cr-Commit-Position: refs/heads/master@{#390143}

Powered by Google App Engine
This is Rietveld 408576698