Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1746973002: bluetooth: Fix leak in getCharacteristics (Closed)

Created:
4 years, 9 months ago by ortuno
Modified:
4 years, 9 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Fix leak in getCharacteristics We were not properly removing the callbacks from the map. WebKit Linux Leak caught a leak in the getCharacteristics LayoutTests: ({"numberOfLiveActiveDOMObjects":[2,3]}) https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Leak/17788/layout-test-results/results.html Reproduced locally by running run_layout_tests.sh with --enable-leak-detection. BUG=590865 Committed: https://crrev.com/542f9e5244355165647f0a6897b7c44bdc92503b Cr-Commit-Position: refs/heads/master@{#378339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/bluetooth/bluetooth_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
ortuno
scheib: PTAL
4 years, 9 months ago (2016-02-29 21:59:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746973002/1
4 years, 9 months ago (2016-02-29 21:59:33 UTC) #4
ortuno
4 years, 9 months ago (2016-02-29 21:59:57 UTC) #5
scheib
LGTM, but please explain in description how to verify that this fixes the issue.
4 years, 9 months ago (2016-02-29 22:02:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 00:08:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746973002/1
4 years, 9 months ago (2016-03-01 00:15:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 00:24:46 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 00:26:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/542f9e5244355165647f0a6897b7c44bdc92503b
Cr-Commit-Position: refs/heads/master@{#378339}

Powered by Google App Engine
This is Rietveld 408576698