Follow ClassTypeAlias constructor redirections.

Follow ClassTypeAlias constructor redirections.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3a401c3d5913e02ddfa086f6913ef936759e85c0

[Brian Wilkerson, 2016-02-29 21:27:18]

LGTM

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:564: if
(constructor.redirectedConstructor == false) {
"false"?

Do we need this test anyway? Isn't it going to drop out of the while and then
return the constructor at the end of the method?

[Paul Berry, 2016-02-29 21:28:01]

lgtm, assuming the bug is fixed and unit tests are updated appropriately.

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:563: // done if no another
redirection
s/no another redirection/no more redirections/

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:564: if
(constructor.redirectedConstructor == false) {
I think you mean `== null`, not `== false`.

But I'm concerned that this bug wasn't found by unit tests.  Is it possible to
write a unit test that would have caught this bug?  If so, we should add that
test.  If not, perhaps this "if" test is not needed at all.

[scheglov, 2016-02-29 22:11:55]

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1746963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:564: if
(constructor.redirectedConstructor == false) {
On 2016/02/29 21:27:18, Brian Wilkerson wrote:
> "false"?
> 
> Do we need this test anyway? Isn't it going to drop out of the while and then
> return the constructor at the end of the method?

Well, yes, it is going to drop out of the while on the next cycle.
But I as trying to avoid creating a new Set when we have just one redirection.
But maybe this is a premature optimization.
So, I'm removing this code and switch to always creating a new Set.

[scheglov, 2016-02-29 22:13:34]

Description was changed from

==========
Follow ClassTypeAlias constructor redirections.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Follow ClassTypeAlias constructor redirections.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3a401c3d5913e02ddfa086f6913ef936759e85c0
==========

[scheglov, 2016-02-29 22:13:35]

Committed patchset #2 (id:20001) manually as
3a401c3d5913e02ddfa086f6913ef936759e85c0 (presubmit successful).