Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: tools/debugger/SkDebugCanvas.cpp

Issue 1746953002: fix minor bug drawing batch bounds by default (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/debugger/SkDebugCanvas.h ('k') | tools/skiaserve/Request.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCanvasPriv.h" 8 #include "SkCanvasPriv.h"
9 #include "SkClipStack.h" 9 #include "SkClipStack.h"
10 #include "SkDebugCanvas.h" 10 #include "SkDebugCanvas.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 SkDebugCanvas::SkDebugCanvas(int width, int height) 69 SkDebugCanvas::SkDebugCanvas(int width, int height)
70 : INHERITED(width, height) 70 : INHERITED(width, height)
71 , fPicture(nullptr) 71 , fPicture(nullptr)
72 , fFilter(false) 72 , fFilter(false)
73 , fMegaVizMode(false) 73 , fMegaVizMode(false)
74 , fOverdrawViz(false) 74 , fOverdrawViz(false)
75 , fOverrideFilterQuality(false) 75 , fOverrideFilterQuality(false)
76 , fFilterQuality(kNone_SkFilterQuality) 76 , fFilterQuality(kNone_SkFilterQuality)
77 , fClipVizColor(SK_ColorTRANSPARENT) 77 , fClipVizColor(SK_ColorTRANSPARENT)
78 , fDrawGpuBatchBounds(true) { 78 , fDrawGpuBatchBounds(false) {
79 fUserMatrix.reset(); 79 fUserMatrix.reset();
80 80
81 // SkPicturePlayback uses the base-class' quickReject calls to cull clipped 81 // SkPicturePlayback uses the base-class' quickReject calls to cull clipped
82 // operations. This can lead to problems in the debugger which expects all 82 // operations. This can lead to problems in the debugger which expects all
83 // the operations in the captured skp to appear in the debug canvas. To 83 // the operations in the captured skp to appear in the debug canvas. To
84 // circumvent this we create a wide open clip here (an empty clip rect 84 // circumvent this we create a wide open clip here (an empty clip rect
85 // is not sufficient). 85 // is not sufficient).
86 // Internally, the SkRect passed to clipRect is converted to an SkIRect and 86 // Internally, the SkRect passed to clipRect is converted to an SkIRect and
87 // rounded out. The following code creates a nearly maximal rect that will 87 // rounded out. The following code creates a nearly maximal rect that will
88 // not get collapsed by the coming conversions (Due to precision loss the 88 // not get collapsed by the coming conversions (Due to precision loss the
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 } 705 }
706 706
707 bool SkDebugCanvas::lastClipStackData(const SkPath& devPath) { 707 bool SkDebugCanvas::lastClipStackData(const SkPath& devPath) {
708 if (fCalledAddStackData) { 708 if (fCalledAddStackData) {
709 fClipStackData.appendf("<br>"); 709 fClipStackData.appendf("<br>");
710 addPathData(devPath, "pathOut"); 710 addPathData(devPath, "pathOut");
711 return true; 711 return true;
712 } 712 }
713 return false; 713 return false;
714 } 714 }
OLDNEW
« no previous file with comments | « tools/debugger/SkDebugCanvas.h ('k') | tools/skiaserve/Request.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698