Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1746843002: Persist the user's active audio device choice across chromeos session and reboots. (Closed)

Created:
4 years, 9 months ago by jennyz
Modified:
4 years, 9 months ago
Reviewers:
hychao
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, hashimoto+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Persist the user's active audio device choice across chromeos session and reboots. This cl added a new attribute to device's active state settings to describe if the device is made active by user's selection or by automatic priority selection. The device made active by user has a higher priority than the device made active by priority. With the stable device id, the active device selection rule is different than before, which only select the active device by its priority. Please see the details in the following document. https://docs.google.com/a/google.com/document/d/1zmSeM956Njh_9ZdLqyld-NTOpJyXVIfzv8DvQ1Xcksw/edit?usp=sharing BUG=308143 TBR=stevenjb,rkc,derat Committed: https://crrev.com/bd23674643e0993e443ef785e80b9ad2e3e9adf4 Cr-Commit-Position: refs/heads/master@{#378812}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+802 lines, -253 lines) Patch
M ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler.h View 2 chunks +13 lines, -17 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.cc View 1 chunk +35 lines, -16 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl_unittest.cc View 2 chunks +25 lines, -15 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_stub.h View 3 chunks +13 lines, -5 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_stub.cc View 1 chunk +18 lines, -9 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 8 chunks +74 lines, -19 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 14 chunks +330 lines, -157 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 1 11 chunks +260 lines, -7 lines 0 comments Download
M chromeos/dbus/cras_audio_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cras_audio_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cras_audio_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/audio/audio_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jennyz
4 years, 9 months ago (2016-02-29 18:16:47 UTC) #3
hychao
lgtm https://codereview.chromium.org/1746843002/diff/1/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/1746843002/diff/1/chromeos/audio/cras_audio_handler.cc#newcode1028 chromeos/audio/cras_audio_handler.cc:1028: // |hotplug_device} is plugged in for the first ...
4 years, 9 months ago (2016-03-02 15:34:06 UTC) #4
jennyz
https://codereview.chromium.org/1746843002/diff/1/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/1746843002/diff/1/chromeos/audio/cras_audio_handler.cc#newcode1028 chromeos/audio/cras_audio_handler.cc:1028: // |hotplug_device} is plugged in for the first time, ...
4 years, 9 months ago (2016-03-02 19:33:37 UTC) #5
jennyz
4 years, 9 months ago (2016-03-02 19:37:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746843002/20001
4 years, 9 months ago (2016-03-02 19:37:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 20:16:02 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 20:17:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd23674643e0993e443ef785e80b9ad2e3e9adf4
Cr-Commit-Position: refs/heads/master@{#378812}

Powered by Google App Engine
This is Rietveld 408576698