Remove _FXLIB_NEW_VERSION_ as it is always defined.

Remove _FXLIB_NEW_VERSION_ as it is always defined.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/45a23fd1c24cb3c22cfd8406ed7247e9d84887be

[dsinclair, 2016-02-29 16:54:47]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-02-29 16:54:48]

PTAL.

[Tom Sepez, 2016-02-29 17:05:36]

lgtm

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
File xfa/src/fxfa/src/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:327: return
(CFX_DIBitmap*)imageDIBDpi->pDibSource;
nit: cast not needed here, its an upcast.

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:330: if (pRoot == NULL) {
Nit: various nits here, feel free to clean up as you like, e.g.
!pRoot

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:331: return NULL;
nit: nullptr;

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:335: return NULL;
nit: nullptr

[dsinclair, 2016-02-29 17:56:45]

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
File xfa/src/fxfa/src/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:327: return
(CFX_DIBitmap*)imageDIBDpi->pDibSource;
On 2016/02/29 17:05:36, Tom Sepez wrote:
> nit: cast not needed here, its an upcast.

Changed to a static_cast otherwise:

error: cannot initialize return object of type 'CFX_DIBitmap *' with an lvalue
of type 'CFX_DIBSource *'

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:330: if (pRoot == NULL) {
On 2016/02/29 17:05:36, Tom Sepez wrote:
> Nit: various nits here, feel free to clean up as you like, e.g.
> !pRoot

Done.

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:331: return NULL;
On 2016/02/29 17:05:36, Tom Sepez wrote:
> nit: nullptr;

Done.

https://codereview.chromium.org/1746803002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffdoc.cpp:335: return NULL;
On 2016/02/29 17:05:36, Tom Sepez wrote:
> nit: nullptr

Done.

[dsinclair, 2016-02-29 17:57:08]

Description was changed from

==========
Remove _FXLIB_NEW_VERSION_ as it is always defined.
==========

to

==========
Remove _FXLIB_NEW_VERSION_ as it is always defined.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/45a23fd1c24cb3c22cfd8406ed7247e9d848...
==========

[dsinclair, 2016-02-29 17:57:09]

Committed patchset #2 (id:20001) manually as
45a23fd1c24cb3c22cfd8406ed7247e9d84887be (presubmit successful).