chrome://identity-internals code quality

chrome/browser/resources/identity_internals.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('identity_internals', function() {
   'use strict';
 
   /**
    * Creates an identity token item.
-   * @param {Object} tokenInfo Object containing token information.
+   * @param {!Object} tokenInfo Object containing token information.
    * @constructor
    */
   function TokenListItem(tokenInfo) {
     var el = cr.doc.createElement('div');
     el.data_ = tokenInfo;
     el.__proto__ = TokenListItem.prototype;
     el.decorate();
     return el;
   }
 
   TokenListItem.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /** @override */
     decorate: function() {
       this.textContent = '';
-      this.id = this.data_.tokenId;
+      this.id = this.data_.accessToken;
 
       var table = this.ownerDocument.createElement('table');
       var tbody = this.ownerDocument.createElement('tbody');
       tbody.appendChild(this.createEntry_(
-          'tokenId', this.data_.tokenId, 'token-id'));
+          'accessToken', this.data_.accessToken, 'access-token'));
       tbody.appendChild(this.createEntry_(
           'extensionName', this.data_.extensionName, 'extension-name'));
       tbody.appendChild(this.createEntry_(
           'extensionId', this.data_.extensionId, 'extension-id'));
       tbody.appendChild(this.createEntry_(
           'tokenStatus', this.data_.status, 'token-status'));
       tbody.appendChild(this.createEntry_(
           'expirationTime', this.data_.expirationTime, 'expiration-time'));
       tbody.appendChild(this.createEntryForScopes_());
       table.appendChild(tbody);
@@ skipping 64 matching lines @@
      * Creates a revoke button with an event sending a revoke token message
      * to the controller.
      * @return {!HTMLButtonElement} The created revoke button.
      * @private
      */
     createRevokeButton_: function() {
       var revokeButton = this.ownerDocument.createElement('button');
       revokeButton.classList.add('revoke-button');
       revokeButton.addEventListener('click', function() {
         chrome.send('identityInternalsRevokeToken',
-                    [this.data_.extensionId, this.data_.tokenId]);
+                    [this.data_.extensionId, this.data_.accessToken]);
       }.bind(this));
       revokeButton.textContent = loadTimeData.getString('revoke');
       return revokeButton;
     },
   };
 
   /**
    * Creates a new list of identity tokens.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
@@ skipping 15 matching lines @@
      */
     showTokenNodes_: function() {
       this.data_.forEach(function(tokenInfo) {
         this.appendChild(new TokenListItem(tokenInfo));
       }, this);
     },
 
     /**
      * Removes a token node related to the specifed token ID from both the
      * internals data source as well as the user internface.
-     * @param {string} tokenId The id of the token to remove.
+     * @param {string} accessToken The id of the token to remove.
      * @private
      */
-    removeTokenNode_: function(tokenId) {
+    removeTokenNode_: function(accessToken) {
       var tokenIndex;
       for (var index = 0; index < this.data_.length; index++) {
-        if (this.data_[index].tokenId == tokenId) {
+        if (this.data_[index].accessToken == accessToken) {
           tokenIndex = index;
           break;
         }
       }
 
       // Remove from the data_ source if token found.
       if (tokenIndex)
         this.data_.splice(tokenIndex, 1);
 
       // Remove from the user interface.
-      var tokenNode = $(tokenId);
+      var tokenNode = $(accessToken);
       if (tokenNode)
         this.removeChild(tokenNode);
     },
   };
 
   var tokenList_;
 
   /**
    * Initializes the UI by asking the contoller for list of identity tokens.
    */
   function initialize() {
     chrome.send('identityInternalsGetTokens');
     tokenList_ = $('token-list');
     tokenList_.data_ = [];
     tokenList_.__proto__ = TokenList.prototype;
     tokenList_.decorate();
   }
 
   /**
    * Callback function accepting a list of tokens to be displayed.
-   * @param {Token[]} tokens A list of tokens to be displayed
+   * @param {!Token[]} tokens A list of tokens to be displayed
    */
   function returnTokens(tokens) {
     tokenList_.data_ = tokens;
     tokenList_.showTokenNodes_();
   }
 
   /**
    * Callback function that removes a token from UI once it has been revoked.
-   * @param {!Array.<string>} tokenIds Array with a single element, which is a
-   * token ID, of the token to be removed.
+   * @param {!Array.<string>} accessTokens Array with a single element, which is
+   * an access token, of the token to be removed.

[Michael Courage, 2013/06/20 09:40:54]

This is slightly awkward phrasing after the rename. Maybe "which is the access
token to be removed"

[arv (Not doing code reviews), 2013/06/20 14:06:40]

Yeah, that would read better.

[fgorski, 2013/06/20 16:28:48]

Done. And yes... a little embarrassed.  

    */
-  function tokenRevokeDone(tokenIds) {
-    assert(tokenIds.length > 0);
-    tokenList_.removeTokenNode_(tokenIds[0]);
+  function tokenRevokeDone(accessTokens) {
+    assert(accessTokens.length > 0);
+    tokenList_.removeTokenNode_(accessTokens[0]);
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize,
     returnTokens: returnTokens,
     tokenRevokeDone: tokenRevokeDone,
   };
 });
 
 document.addEventListener('DOMContentLoaded', identity_internals.initialize);