Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1746673002: Node.h #include parsimony. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, eric.carlson_apple.com, Eric Willigers, f(malita), fs, gavinp+loader_chromium.org, gasubic, gyuyoung2, Nate Chapin, jchaffraix+rendering, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, nessy, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, vcarbune.chromium, webcomponents-bugzilla_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Node.h #include parsimony. Node.h is slurped in throughout Blink, hence it makes sense to have it not include unnecessary headers. R=tkent BUG= Committed: https://crrev.com/870d7ed29cd1d7aaa68296474bfd6cbd4fd642cf Cr-Commit-Position: refs/heads/master@{#378427}

Patch Set 1 #

Patch Set 2 : remove unrelated change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DEPS View 1 chunk +1 line, -0 lines 1 comment Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look & consider. (low priority stuff.) https://codereview.chromium.org/1746673002/diff/20001/third_party/WebKit/Source/core/fetch/DEPS File third_party/WebKit/Source/core/fetch/DEPS (right): https://codereview.chromium.org/1746673002/diff/20001/third_party/WebKit/Source/core/fetch/DEPS#newcode13 third_party/WebKit/Source/core/fetch/DEPS:13: ...
4 years, 9 months ago (2016-02-29 09:27:00 UTC) #4
tkent
lgtm
4 years, 9 months ago (2016-02-29 23:16:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746673002/20001
4 years, 9 months ago (2016-03-01 12:31:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 13:55:29 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 13:56:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/870d7ed29cd1d7aaa68296474bfd6cbd4fd642cf
Cr-Commit-Position: refs/heads/master@{#378427}

Powered by Google App Engine
This is Rietveld 408576698