re-land: Use browser compositor rendering stats in smoothness

re-land: Use browser compositor rendering stats in smoothness

PERF SHERRIFS: This patch can change the metrics of smoothness up or down.
The new values should be more accurate than what we had before. If there are
large changes on a platform, we should still sanity check that everything works
as expected.

Switch smoothness benchmark to use rendering stats from the top level
compositor; i.e. if data from a browser compositor is available, use that.
Otherwise use the data from the renderer compositor.

The re-land fixes the problem where a browser compositor was present, but
didn't record rendering stats. That was the case with the reference
builds (that didn't have the patch that enabled recording) and on Android.
The new version checks if the browser compositor rendering stats events
actually have frames in them. If not, the render compositor stats will be used.
There is also a fix on the way to enable the recording on Android
(https://codereview.chromium.org/168193004/).

R=tonyg@chromium.org,nduca@chromium.org
BUG=340753
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254811

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260256

[ernstm, 2014-02-21 21:31:43]

PTAL.

[tonyg, 2014-02-22 15:18:51]

Chunk mismatch, can you re-upload please?

[ernstm, 2014-02-24 17:34:39]

Rebased. Please try again.

[nduca, 2014-02-26 10:44:52]

needs unit test coverage

[ernstm, 2014-02-26 19:11:23]

On 2014/02/26 10:44:52, nduca wrote:
> needs unit test coverage

Done.

[ernstm, 2014-03-03 22:39:39]

On 2014/02/26 19:11:23, ernstm wrote:
> On 2014/02/26 10:44:52, nduca wrote:
> > needs unit test coverage
> 
> Done.

Friendly ping :-)

[tonyg, 2014-03-03 22:58:50]

lgtm

[nduca, 2014-03-04 03:32:06]

alsolgtm

[ernstm, 2014-03-04 05:47:48]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-03-04 05:48:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/174663008/100001

[commit-bot: I haz the power, 2014-03-04 07:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 07:11:47]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[tonyg, 2014-03-04 15:13:34]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-03-04 15:13:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/174663008/100001

[commit-bot: I haz the power, 2014-03-04 20:32:53]

Change committed as 254811

[Ilya Sherman, 2014-03-05 07:02:44]

A revert of this CL has been created in
https://codereview.chromium.org/187343004/ by isherman@chromium.org.

The reason for reverting is: Broke the smoothness perf tests on multiple bots.

BUG=349338.

[ernstm, 2014-03-24 22:39:46]

This failed because timeline.browser_process can be None on some platforms.
Added a check for that case. Falling back to renderer compositor timestamps if
browser_process is None. Investigating separately (crbug.com/349549) why this
happens.

Any concerns about re-landing with that fix?

[tonyg, 2014-03-27 23:02:34]

lgtm

[ernstm, 2014-03-27 23:17:02]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:18:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/174663008/120001

[commit-bot: I haz the power, 2014-03-28 01:09:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:09:53]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[ernstm, 2014-03-28 18:00:01]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-03-28 18:01:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/174663008/120001

[commit-bot: I haz the power, 2014-03-28 20:18:49]

Change committed as 260256