Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/IceInstX86BaseImpl.h

Issue 1746613002: Subzero: Reduce copying of Liveness bitvectors. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix huge perf problem in MINIMAL build Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceCfgNode.cpp ('K') | « src/IceCfgNode.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstX86BaseImpl.h
diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h
index 64d235e6e57211e900396a7f999a50db10643e1f..a6ce132fc8f2e9ce056e4d621088ee52b4df1551 100644
--- a/src/IceInstX86BaseImpl.h
+++ b/src/IceInstX86BaseImpl.h
@@ -98,8 +98,11 @@ InstImpl<TraitsType>::InstX86Label::InstX86Label(Cfg *Func,
template <typename TraitsType>
IceString InstImpl<TraitsType>::InstX86Label::getName(const Cfg *Func) const {
+ // TODO(stichnot): Returning an empty string in a non-DUMP build can cause a
+ // huge degradation in ConstantRelocatable hashing. Investigate and fix, but
+ // for now return something reasonably unique.
if (!BuildDefs::dump())
- return IceString();
+ return Func->getFunctionName() + std::to_string(Number);
return ".L" + Func->getFunctionName() + "$local$__" + std::to_string(Number);
}
« src/IceCfgNode.cpp ('K') | « src/IceCfgNode.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698